1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
rails--rails/activerecord/test/support
Eileen Uchitelle 8d32346cde Add ability to change the names of the default handlers
When I wrote the `connected_to` and `connects_to` API's I wrote them
with the idea in mind that it didn't really matter what the
handlers/roles were called as long as those connecting to the roles knew
which one wrote and which one read.

With the introduction of the middleware Rails begins to assume it's
`writing` and `reading` and there's no room for other roles. At GitHub
we've been using this method for a long time so we have a ton of legacy
code that uses different handler names `default` and `readonly`. We
could rename all our code but I think this is better for a few reasons:

- Legacy apps that have been using multiple databases for a long time
  can have an eaiser time switching.
- If we later find this to cause more issues than it's worth we can
  easily deprecate.
- We won't force old apps to rewrite the resolver middleware just to use
  a different handler.

Adding the writing_role/reading_role required that I move the code that
creates the first handler for writing to the railtie. If I didn't move
this the core class would assign the handler before I was able to assign
a new one in my configuration and I'd end up with 3 handlers instead of
2.
2019-02-01 14:11:35 -05:00
..
stubs Ensure that AR::Relation#exists? allows only permitted params 2019-01-17 20:10:01 +00:00
yaml_compatibility_fixtures
config.rb Upgrade Rubocop to 0.61.1 and fix offenses 2018-12-10 19:22:56 -02:00
connection.rb Add ability to change the names of the default handlers 2019-02-01 14:11:35 -05:00
connection_helper.rb Use frozen-string-literal in ActiveRecord 2017-07-19 22:27:07 +03:00
ddl_helper.rb Use frozen-string-literal in ActiveRecord 2017-07-19 22:27:07 +03:00
schema_dumping_helper.rb Use frozen-string-literal in ActiveRecord 2017-07-19 22:27:07 +03:00