rails--rails/activerecord/test/models/room.rb at f0f067af78529f7e2a24a14cfddc1f00e6acc8ae - kotovalexarian-likes-github/rails--rails - Forgejo by Causa Arcana

kotovalexarian-likes-github/rails--rails

mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00

ktmouk 5b4a516c1c Fixed odd behavior of inverse_of with multiple belongs_to to same class

Fix: #35204.

This PR added validation to `automatic_inverse_of` that foreign_keys are the same.

If class has multiple `belongs_to` to same class, `automatic_inverse_of` can find the wrong `inverse_name`.

```ruby
class Room < ActiveRecord::Base
  belongs_to :user
  belongs_to :owner, class_name: "User"
end

class User < ActiveRecord::Base
  has_one :room
  has_one :owned_room, class_name: "Room", foreign_key: "owner_id"
end

user = User.create!
owned_room = Room.create!(owner: user)

p user.room
```

The current `automatic_inverse_of` validates the `reflection` that found from associations.
However, its validation does not validate that foreign keys are the same.

so this issue can be fixed by adding a validation of foreign keys.

Co-authored-by: alpaca-tc <alpaca-tc@alpaca.tc>
Co-authored-by: cat2koban <taba.noritomo@moneyforward.co.jp>
Co-authored-by: luccafort <konishi.tatsuro@moneyforward.co.jp>

2020-11-21 02:06:21 +09:00

6 lines

126 B

Ruby

Raw Blame History

 # frozen_string_literal: true
 class Room < ActiveRecord::Base
   belongs_to :user
   belongs_to :owner, class_name: "User"
 end