1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
rails--rails/activestorage/test/previewer
Alex Robbin d6197d4c86 Active Storage: raise PreviewError when a preview cannot be generated
If a preview cannot be generated, the IO stream that is captured is empty, resulting in a 0-byte preview file being generated and stored in the Active Storage service.

We came across this because Poppler was failing to generate previews of some PDFs, resulting in 0-byte files. Resizing those "previews" then resulted in a MiniMagick error. The MiniMagick error feels like the right end result if it's attempted on a 0-byte file, what doesn't feel right is `Previewer` proceeding normally if the child process that attempted to capture a preview exited unsuccessfully.

Now, if the previewer child process exits with a non-0 status code, we raise an exception.
2021-02-26 14:06:52 -05:00
..
mupdf_previewer_test.rb Active Storage: raise PreviewError when a preview cannot be generated 2021-02-26 14:06:52 -05:00
poppler_pdf_previewer_test.rb Active Storage: raise PreviewError when a preview cannot be generated 2021-02-26 14:06:52 -05:00
video_previewer_test.rb Active Storage: raise PreviewError when a preview cannot be generated 2021-02-26 14:06:52 -05:00