1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
rails--rails/actionpack/lib/action_dispatch/journey
eileencodes ec14aad419 Fix route creation when format is a blank string
Commit bff61ba, while reducing allocations, caused a regression when an empty
format is passed to a route.

This can happen in cases where you're using an anchor tag, for example:
`https://example.com/parent/575256966.#child_1032289285`.

Because of this change `format` was getting sent in
`parameterized_parts` when previously it was not included. This resulted
in blank `format`'s being returned as `.` when if there was an extension
included it would be `.extension`. Since there was no extension this
caused incorrect URL's.

The test shows this would result in `/posts/show/1.` instead of
`/posts/show/1` which causes bad urls since the format is not present.
2015-09-02 09:18:46 -04:00
..
gtg Remove some comments about Ruby 1.9 behaviors 2015-01-04 15:55:28 -03:00
nfa remove unused #generalized_table 2014-12-05 16:09:03 +03:00
nodes drop array allocations when building paths 2015-08-18 15:57:11 -07:00
path avoid is_a? checks 2015-08-17 15:28:23 -07:00
router remove Strexp 2015-08-13 15:42:46 -07:00
visualizer CSS fix for the router visualizer 2014-11-25 18:46:01 +01:00
backwards.rb
formatter.rb Fix route creation when format is a blank string 2015-09-02 09:18:46 -04:00
parser.rb Using no_result_var in Journey's parser generator 2014-08-03 15:23:56 -07:00
parser.y Using no_result_var in Journey's parser generator 2014-08-03 15:23:56 -07:00
parser_extras.rb pull up path parsing 2015-08-14 10:39:33 -07:00
route.rb set route precedence at allocation time 2015-08-20 15:34:18 -07:00
router.rb use predicate methods instead of hard coding verb strings 2015-08-14 10:39:33 -07:00
routes.rb move route allocation to a factory method on the mapping object 2015-08-15 14:34:37 -07:00
scanner.rb Use #tr instead of #gsub 2014-10-14 22:32:23 +02:00
visitors.rb drop object allocation during routes setup 2015-08-17 15:57:06 -07:00