mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
05ad44eb89
- Following the Rails guide which state that a logger needs to include the `ActiveSupport::LoggerSilence` as well as `ActiveSupport::LoggerThreadSafe` modules isn't enough and won't work. Here is a test cases with 3 tests that all fails https://gist.github.com/Edouard-chin/4a72930c2b1eafbbd72a80c66f102010 The problems are the following: 1) The logger needs to call `after_initialize` in order to setup some instance variables. 2) The silence doesn't actually work because the bare ruby Logger `add` method checks for the instance variable `@logger`. We need to override the `add` (like we used to in the ActiveSupport::Logger class). 3) Calling `debug?` `info?` etc... doesn't work as the bare ruby methods will check for the instance variable. Again we need to override this methods (like we used to in the ActiveSupport::Logger class) The LoggerSilence won't work without LoggerThreadSafe, but the later is not public API, the user shouldn't have to include it so I modified to include it automatically. Same for the `after_initialize` method. I find unuintitive to have to call it directly. I modified to instance the variables when the module get included.
45 lines
1.1 KiB
Ruby
45 lines
1.1 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require "active_support/concern"
|
|
require "active_support/core_ext/module/attribute_accessors"
|
|
require "active_support/logger_thread_safe_level"
|
|
|
|
module LoggerSilence
|
|
extend ActiveSupport::Concern
|
|
|
|
included do
|
|
ActiveSupport::Deprecation.warn(
|
|
"Including LoggerSilence is deprecated and will be removed in Rails 6.1. " \
|
|
"Please use `ActiveSupport::LoggerSilence` instead"
|
|
)
|
|
|
|
include ActiveSupport::LoggerSilence
|
|
end
|
|
end
|
|
|
|
module ActiveSupport
|
|
module LoggerSilence
|
|
extend ActiveSupport::Concern
|
|
|
|
included do
|
|
cattr_accessor :silencer, default: true
|
|
include ActiveSupport::LoggerThreadSafeLevel
|
|
end
|
|
|
|
# Silences the logger for the duration of the block.
|
|
def silence(temporary_level = Logger::ERROR)
|
|
if silencer
|
|
begin
|
|
old_local_level = local_level
|
|
self.local_level = temporary_level
|
|
|
|
yield self
|
|
ensure
|
|
self.local_level = old_local_level
|
|
end
|
|
else
|
|
yield self
|
|
end
|
|
end
|
|
end
|
|
end
|