mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
0cdeee428e
- ### Problem
In some cirumstances, the deprecation message to warn that AJ won't
run `after_(enqueue/perform)` callbacks when the chain is halted
by a `throw(:abort)` will be thrown even though no `throw(:abort)`
was thrown.
```ruby
run_callback(:foo) do
...
end
```
There is two possible way for the callback body to not be executed:
1) `before` callback throw a `abort`
2) `before` callback raises an error which is rescued by an
around callback (See associated test in this commit for
an example)
When 2) happen we don't want to output a deprecation message,
because what the message says isn't true and doesn't apply.
### Solution
In order to differentiate between 1) and 2), I have added
a `halted_callback_hook` which is called by ActiveSupport callback
whenever the callback chain is halted.
58 lines
1.6 KiB
Ruby
58 lines
1.6 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require "active_support/rescuable"
|
|
require "active_job/arguments"
|
|
|
|
module ActiveJob
|
|
module Execution
|
|
extend ActiveSupport::Concern
|
|
include ActiveSupport::Rescuable
|
|
|
|
# Includes methods for executing and performing jobs instantly.
|
|
module ClassMethods
|
|
# Performs the job immediately.
|
|
#
|
|
# MyJob.perform_now("mike")
|
|
#
|
|
def perform_now(*args)
|
|
job_or_instantiate(*args).perform_now
|
|
end
|
|
ruby2_keywords(:perform_now) if respond_to?(:ruby2_keywords, true)
|
|
|
|
def execute(job_data) #:nodoc:
|
|
ActiveJob::Callbacks.run_callbacks(:execute) do
|
|
job = deserialize(job_data)
|
|
job.perform_now
|
|
end
|
|
end
|
|
end
|
|
|
|
# Performs the job immediately. The job is not sent to the queuing adapter
|
|
# but directly executed by blocking the execution of others until it's finished.
|
|
# `perform_now` returns the value of your job's `perform` method.
|
|
#
|
|
# class MyJob < ActiveJob::Base
|
|
# def perform
|
|
# "Hello World!"
|
|
# end
|
|
# end
|
|
#
|
|
# puts MyJob.new(*args).perform_now # => "Hello World!"
|
|
def perform_now
|
|
# Guard against jobs that were persisted before we started counting executions by zeroing out nil counters
|
|
self.executions = (executions || 0) + 1
|
|
|
|
deserialize_arguments_if_needed
|
|
|
|
run_callbacks :perform do
|
|
perform(*arguments)
|
|
end
|
|
rescue => exception
|
|
rescue_with_handler(exception) || raise
|
|
end
|
|
|
|
def perform(*)
|
|
fail NotImplementedError
|
|
end
|
|
end
|
|
end
|