1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
rails--rails/actionview/test
Jonathan Hefner e6950a332a Add label attribute to <option> from include_blank
The `:include_blank` option of various `<select>`-related helpers causes
an `<option>` element with no content to be rendered.  However, the
[HTML spec] says that unless an `<option>` element has a `label`
attribute (which must be non-empty), its content must be "Text that is
not inter-element whitespace."

In #24923, this issue was addressed for `select_tag` by adding a `label`
attribute to the `<option>`.  This commit addresses the issue in the
same manner for `FormBuilder#select` and various date / time select
helpers.

[HTML spec]: https://html.spec.whatwg.org/multipage/form-elements.html#the-option-element
2020-07-24 15:45:18 -05:00
..
actionpack Address to false negative for Performance/DeletePrefix,DeleteSuffix 2020-06-14 13:04:47 +09:00
activerecord Address to false negative for Performance/DeletePrefix,DeleteSuffix 2020-06-14 13:04:47 +09:00
fixtures Add test for HTML format fallback from JS template 2020-05-29 22:07:17 +01:00
lib Document view components support (#38656) 2020-03-13 23:52:49 +01:00
template Add label attribute to <option> from include_blank 2020-07-24 15:45:18 -05:00
ujs Fix typos [ci skip] 2020-04-22 21:43:37 -07:00
abstract_unit.rb Remove redundant @virtual_path variable 2020-05-26 15:53:11 -04:00
active_record_unit.rb Run actionview tests in parallel 2019-06-05 18:40:08 -07:00