mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
7e20bdc20d
This is a regression 4.0 -> 4.1 fix. In 4.1.0 Relation#join is delegated to Arel#SelectManager. In 4.0 series it is delegated to Array#join This patch puts back the behaviour of 4.0
68 lines
1.7 KiB
Ruby
68 lines
1.7 KiB
Ruby
require 'cases/helper'
|
|
require 'models/post'
|
|
require 'models/comment'
|
|
|
|
module ActiveRecord
|
|
class DelegationTest < ActiveRecord::TestCase
|
|
fixtures :posts
|
|
|
|
def call_method(target, method)
|
|
method_arity = target.to_a.method(method).arity
|
|
|
|
if method_arity.zero?
|
|
target.public_send(method)
|
|
elsif method_arity < 0
|
|
if method == :shuffle!
|
|
target.public_send(method)
|
|
else
|
|
target.public_send(method, 1)
|
|
end
|
|
elsif method_arity == 1
|
|
target.public_send(method, 1)
|
|
else
|
|
raise NotImplementedError
|
|
end
|
|
end
|
|
end
|
|
|
|
module DelegationWhitelistBlacklistTests
|
|
ARRAY_DELEGATES = [
|
|
:+, :-, :|, :&, :[],
|
|
:all?, :collect, :detect, :each, :each_cons, :each_with_index,
|
|
:exclude?, :find_all, :flat_map, :group_by, :include?, :length,
|
|
:map, :none?, :one?, :partition, :reject, :reverse,
|
|
:sample, :second, :sort, :sort_by, :third,
|
|
:to_ary, :to_set, :to_xml, :to_yaml, :join
|
|
]
|
|
|
|
ARRAY_DELEGATES.each do |method|
|
|
define_method "test_delegates_#{method}_to_Array" do
|
|
assert_respond_to target, method
|
|
end
|
|
end
|
|
|
|
ActiveRecord::Delegation::BLACKLISTED_ARRAY_METHODS.each do |method|
|
|
define_method "test_#{method}_is_not_delegated_to_Array" do
|
|
assert_raises(NoMethodError) { call_method(target, method) }
|
|
end
|
|
end
|
|
end
|
|
|
|
class DelegationAssociationTest < DelegationTest
|
|
include DelegationWhitelistBlacklistTests
|
|
|
|
def target
|
|
Post.first.comments
|
|
end
|
|
end
|
|
|
|
class DelegationRelationTest < DelegationTest
|
|
include DelegationWhitelistBlacklistTests
|
|
|
|
fixtures :comments
|
|
|
|
def target
|
|
Comment.all
|
|
end
|
|
end
|
|
end
|