kotovalexarian-likes-github/rest-client--rest-client
1
0
Fork 0
mirror of https://github.com/rest-client/rest-client.git synced 2022-11-09 13:49:40 -05:00
Code Releases Activity

support default error messages in RequestFailed to avoid checking if message == "Unknown ..."

Browse source
This commit is contained in:
Pedro Belo 2008-06-11 15:08:31 -07:00
parent 39f3513dae
commit 88660a038b
2 changed files with 12 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/request_errors.rb
View file

@ -19,16 +19,14 @@ module RestClient
@response.code.to_i
end
def message
def message(default = "Unknown error")
return "Resource not found" if http_code == 404
parse_error_xml
parse_error_xml rescue default
end
def parse_error_xml
xml_errors = REXML::Document.new(@response.body).elements.to_a("//errors/error")
xml_errors.empty? ? raise : xml_errors.map { |a| a.text }.join(" / ")
rescue
"Unknown error"
end
end
end

10
spec/request_errors_spec.rb
View file

@ -14,4 +14,14 @@ describe RestClient::RequestFailed do
@error.response = mock('response', :code => '500', :body => 'Syntax error in SQL query: SELECT * FROM ...')
@error.message.should == 'Unknown error'
end
it "accepts a default error message" do
@error.response = mock('response', :code => '500', :body => 'Internal Server Error')
@error.message('Custom default message').should == 'Custom default message'
end
it "doesn't show the default error message when there's something in the xml" do
@error.response = mock('response', :code => '422', :body => '<errors><error>Specific error message</error></errors>')
@error.message('Custom default message').should == 'Specific error message'
end
end