kotovalexarian-likes-github/rest-client--rest-client
1
0
Fork 0
mirror of https://github.com/rest-client/rest-client.git synced 2022-11-09 13:49:40 -05:00
Code Releases Activity

Add tests around SSL cipher defaults behavior.

Browse source
This commit is contained in:
Andy Brody 2014-03-16 14:45:59 -07:00
parent a68d9bd7a2
commit b41a3941c3
1 changed files with 54 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

56
spec/unit/request_spec.rb
View file

@ -16,6 +16,7 @@ describe RestClient::Request do
@net.stub(:use_ssl=)
@net.stub(:verify_mode=)
@net.stub(:verify_callback=)
allow(@net).to receive(:ciphers=)
RestClient.log = nil
end
@ -595,11 +596,12 @@ describe RestClient::Request do
@request.transmit(@uri, 'req', 'payload')
end
it "should not set the ssl_ciphers if not provided" do
it "should not set the ssl_ciphers if set to nil" do
@request = RestClient::Request.new(
:method => :put,
:url => 'https://some/resource',
:payload => 'payload'
:payload => 'payload',
:ssl_ciphers => nil,
)
@net.should_not_receive(:ciphers=)
@http.stub(:request)
@ -608,6 +610,56 @@ describe RestClient::Request do
@request.transmit(@uri, 'req', 'payload')
end
it "should override ssl_ciphers with better defaults with weak default ciphers" do
stub_const(
'::OpenSSL::SSL::SSLContext::DEFAULT_PARAMS',
{
:ssl_version=>"SSLv23",
:verify_mode=>1,
:ciphers=>"ALL:!ADH:!EXPORT:!SSLv2:RC4+RSA:+HIGH:+MEDIUM:+LOW",
:options=>-2147480577,
}
)
@request = RestClient::Request.new(
:method => :put,
:url => 'https://some/resource',
:payload => 'payload',
)
@net.should_receive(:ciphers=).with(RestClient::Request::DefaultCiphers)
@http.stub(:request)
@request.stub(:process_result)
@request.stub(:response_log)
@request.transmit(@uri, 'req', 'payload')
end
it "should not override ssl_ciphers with better defaults with different default ciphers" do
stub_const(
'::OpenSSL::SSL::SSLContext::DEFAULT_PARAMS',
{
:ssl_version=>"SSLv23",
:verify_mode=>1,
:ciphers=>"HIGH:!aNULL:!eNULL:!EXPORT:!LOW:!MEDIUM:!SSLv2",
:options=>-2147480577,
}
)
@request = RestClient::Request.new(
:method => :put,
:url => 'https://some/resource',
:payload => 'payload',
)
@net.should_not_receive(:ciphers=)
@http.stub(:request)
@request.stub(:process_result)
@request.stub(:response_log)
@request.transmit(@uri, 'req', 'payload')
end
it "should set the ssl_client_cert if provided" do
@request = RestClient::Request.new(
:method => :put,