1
0
Fork 0
mirror of https://github.com/rest-client/rest-client.git synced 2022-11-09 13:49:40 -05:00
Commit graph

9 commits

Author SHA1 Message Date
Andy Brody
2e072dcbb2 Test with an image in the public domain. (#607)
Switch to using NASA photo S130-E-012142 of the ISS. It is in the public
domain because it is a work created solely by NASA.

Fixes: #606
2017-07-05 01:40:21 -04:00
Andy Brody
197bb96c94 Use built-in Net::HTTP support for compression.
The Net::HTTP in ruby 2.0+ supports gzip and deflate decoding on its
own. Remove Accept-Encoding from the default headers set, and instead
let Net::HTTP take care of it.

Note: this could break compatibility for users who are setting
Accept-Encoding headers themselves or who expect the body to still be
compressed with `:raw_response => true`.
2017-05-03 23:18:57 -04:00
Andy Brody
4971d1a6e1 Convert specs to RSpec 2.99.2 syntax with Transpec
This conversion is done by Transpec 3.2.2 with the following command:
    transpec

* 317 conversions
    from: obj.should
      to: expect(obj).to

* 160 conversions
    from: obj.stub(:message)
      to: allow(obj).to receive(:message)

* 100 conversions
    from: obj.should_receive(:message)
      to: expect(obj).to receive(:message)

* 30 conversions
    from: lambda { }.should
      to: expect { }.to

* 22 conversions
    from: obj.should_not_receive(:message)
      to: expect(obj).not_to receive(:message)

* 4 conversions
    from: obj.should_not
      to: expect(obj).not_to

* 2 conversions
    from: == expected
      to: eq(expected)

* 1 conversion
    from: expect(collection).to have_at_least(n).items
      to: expect(collection.size).to be >= n

* 1 conversion
    from: obj.unstub(:message)
      to: allow(obj).to receive(:message).and_call_original

For more details: https://github.com/yujinakayama/transpec#supported-conversions
2016-06-05 19:52:16 -04:00
Andy Brody
2dd4b3739d Enable new GET param generation, add tests.
Switch the generation of HTTP GET params over to the new, more
featureful method in Utils, which handles Rack/Rails style nested
parameters. Also add a variety of tests for this functionality.
2015-11-12 00:11:33 -08:00
Andy Brody
3d0fd0b188 Append GET params with & when adding more.
If there is already a '?' in the URL, add additional query params using
'&' instead.

Ideally we would be more clever about this and actually take the URL
into parts and then unparse in a structured way rather than just blindly
appending, but oh well.

Fixes: #402, #96
2015-11-08 00:56:58 -08:00
Andy Brody
5ce0c6ebde Fix up tests for encoding changes.
Add a `.to_hash => {}` for the Net HTTP response mocks.
2015-03-13 18:00:51 -07:00
Andy Brody
238105b17a Change default headers to Accept: */*.
Previously rest-client would prefer application/xml, which doesn't seem
appropriate for a general purpose HTTP library.
2014-11-02 15:57:10 -08:00
Andy Brody
543dbc3816 Fix a large number of style nits.
Working slowly through the rubocop list.
2014-07-08 03:54:01 -07:00
Larry Gilbert
d7a11503af Reorganize specs
* Put unit and integration specs into separate subdirectories
* Consolidate all requires of 'webmock/rspec' into spec_helper.rb
* Use WebMock.{disable!,enable!} for specs calling live server
2013-08-30 18:45:06 -07:00
Renamed from spec/request2_spec.rb (Browse further)