1
0
Fork 0
mirror of https://github.com/rest-client/rest-client.git synced 2022-11-09 13:49:40 -05:00
Commit graph

6 commits

Author SHA1 Message Date
Andy Brody
e99defb99b Merge pull request #261 from gottfrois/fix_209_rescue_errno_etimedout
Rescue Errno::ETIMEDOUT exception. Fixes #209
2014-03-06 23:27:34 -08:00
Andy Brody
825f5bb8b2 Do some sanity checks on cookie names and values.
Validate that cookie names and values don't flagrantly violate RFC 6265
by containing things like control characters or ';'. This will help
prevent users from accidentally breaking boundaries of cookies or the
cookie header.

If you really want to send scary characters, you can set the Cookie
header directly.
2014-03-06 23:20:05 -08:00
Andy Brody
3c95dbd45c Do not CGI.unescape cookies sent in requests.
It isn't appropriate to call CGI.unescape on cookie values: any URI
encoding performed by servers on cookies should remain that way to avoid
sending invalid characters in the Cookie request HTTP header. (e.g. If
you send a cookie containing '%0A', it should send those three octets,
not a newline character.)

Fixes #89
2014-03-06 22:53:27 -08:00
Andy Brody
3dead16474 Add a test on the version number.
This is pretty dumb, but at least it would prevent another 0.0.0
regression.
2014-03-06 18:31:38 -08:00
Pierre-Louis Gottfrois
04640e8ba0 Rescue Errno::ETIMEDOUT exception. Fixes #209 2014-02-17 16:07:53 +01:00
Larry Gilbert
d7a11503af Reorganize specs
* Put unit and integration specs into separate subdirectories
* Consolidate all requires of 'webmock/rspec' into spec_helper.rb
* Use WebMock.{disable!,enable!} for specs calling live server
2013-08-30 18:45:06 -07:00