2018-11-02 19:07:56 -04:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require "pathname"
|
2019-07-31 20:44:46 -04:00
|
|
|
require "rbconfig"
|
2018-11-02 19:07:56 -04:00
|
|
|
|
|
|
|
module Spec
|
|
|
|
module Path
|
2020-05-15 08:31:12 -04:00
|
|
|
def source_root
|
|
|
|
@source_root ||= Pathname.new(ruby_core? ? "../../../.." : "../../..").expand_path(__FILE__)
|
|
|
|
end
|
|
|
|
|
2018-11-02 19:07:56 -04:00
|
|
|
def root
|
2020-05-15 08:31:12 -04:00
|
|
|
@root ||= system_gem_path("gems/bundler-#{Bundler::VERSION}")
|
2018-11-02 19:07:56 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
def gemspec
|
2020-05-15 08:31:12 -04:00
|
|
|
@gemspec ||= source_root.join(relative_gemspec)
|
|
|
|
end
|
|
|
|
|
|
|
|
def relative_gemspec
|
|
|
|
@relative_gemspec ||= ruby_core? ? "lib/bundler/bundler.gemspec" : "bundler.gemspec"
|
2018-11-02 19:07:56 -04:00
|
|
|
end
|
|
|
|
|
2019-08-16 02:45:11 -04:00
|
|
|
def gemspec_dir
|
|
|
|
@gemspec_dir ||= gemspec.parent
|
|
|
|
end
|
|
|
|
|
2020-05-15 08:31:12 -04:00
|
|
|
def loaded_gemspec
|
|
|
|
@loaded_gemspec ||= Gem::Specification.load(gemspec.to_s)
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_gemfile
|
|
|
|
@test_gemfile ||= source_root.join(ruby_core? ? "tool/bundler/test_gems.rb" : "test_gems.rb")
|
|
|
|
end
|
|
|
|
|
|
|
|
def dev_gemfile
|
|
|
|
@dev_gemfile ||= source_root.join("dev_gems.rb")
|
|
|
|
end
|
|
|
|
|
2018-11-02 19:07:56 -04:00
|
|
|
def bindir
|
2020-05-15 08:31:12 -04:00
|
|
|
@bindir ||= source_root.join(ruby_core? ? "libexec" : "exe")
|
|
|
|
end
|
|
|
|
|
|
|
|
def installed_bindir
|
|
|
|
@installed_bindir ||= system_gem_path("bin")
|
2018-11-02 19:07:56 -04:00
|
|
|
end
|
|
|
|
|
2019-12-14 07:19:28 -05:00
|
|
|
def gem_cmd
|
2020-05-15 08:31:12 -04:00
|
|
|
@gem_cmd ||= ruby_core? ? source_root.join("bin/gem") : "gem"
|
2019-12-14 07:19:28 -05:00
|
|
|
end
|
|
|
|
|
2019-08-15 12:12:34 -04:00
|
|
|
def gem_bin
|
2019-12-14 07:19:28 -05:00
|
|
|
@gem_bin ||= ruby_core? ? ENV["GEM_COMMAND"] : "gem"
|
2019-08-15 12:12:34 -04:00
|
|
|
end
|
|
|
|
|
2020-05-15 08:31:12 -04:00
|
|
|
def path
|
|
|
|
env_path = ENV["PATH"]
|
|
|
|
env_path = env_path.split(File::PATH_SEPARATOR).reject {|path| path == bindir.to_s }.join(File::PATH_SEPARATOR) if ruby_core?
|
|
|
|
env_path
|
|
|
|
end
|
|
|
|
|
2018-11-02 19:07:56 -04:00
|
|
|
def spec_dir
|
2020-05-15 08:31:12 -04:00
|
|
|
@spec_dir ||= source_root.join(ruby_core? ? "spec/bundler" : "spec")
|
2018-11-02 19:07:56 -04:00
|
|
|
end
|
|
|
|
|
2019-08-15 10:48:42 -04:00
|
|
|
def tracked_files
|
2020-05-15 08:31:12 -04:00
|
|
|
@tracked_files ||= git_ls_files(tracked_files_glob)
|
Fix some bundler specs (#2380)
* These seem to consistenly pass already
* Show actual command when running `make test-bundler`
Current the setup command that installs the necessary gems for testing
bundler was printed, but not the actual command that runs the tests.
That was a bit confusing.
* Borrow trick from setproctitle specs
* A title that long doesn't get set sometimes
No idea why, but the test doesn't need that the title is that long.
* Fix most gem helper spec ruby-core failures
* Fix the rest of the gem helper failures
* Fix version spec by improving the assertion
* Remove unnecessary `BUNDLE_RUBY` environment var
We can use `RUBY` when necessary, and `BUNDLE_RUBY` is not a good name
because bundler considers `BUNDLE_*` variables as settings.
* Rename `BUNDLE_GEM` to `GEM_COMMAND`
This is more descriptive I think, and also friendlier for bundler
because `BUNDLE_` env variables are interpreted by bundler as settings,
and this is not a bundler setting.
This fixes one bundler spec failure in config specs against ruby-core.
* Fix quality spec when run in core
Use the proper path helper.
* Fix dummy lib builder to never load default gems
If a dummy library is named as a default gem, when requiring the library
from its executable, the default gem would be loaded when running from
core, because in core all default gems share path with bundler, and thus
they are always in the $LOAD_PATH. We fix the issue by loading lib
relatively inside dummy lib executables.
* More exact assertions
Sometimes I have the problem that I do some "print debugging" inside
specs, and suddently the spec passes. This happens when the assertion is
too relaxed, and the things I print make it match, specially when they
are simple strings like "1.0" than can be easily be part of gem paths
that I print for debugging.
I fix this by making a more exact assertion.
* Detect the correct shebang when ENV["RUBY"] is set
* Relax assertion
So that the spec passes even if another paths containing "ext" are in
the load path. This works to fix a ruby-core issue, but it's a better
assertion in general. We just want to know that the extension path was
added.
* Use folder structure independent path helper
It should fix this spec for ruby-core.
* Fix the last failing spec on ruby-core
* Skip `bundle open <default_gem>` spec when no default gems
2019-08-19 20:46:31 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
def shipped_files
|
2020-05-25 14:32:23 -04:00
|
|
|
@shipped_files ||= loaded_gemspec.files
|
2019-08-15 10:48:42 -04:00
|
|
|
end
|
|
|
|
|
2019-08-15 10:59:08 -04:00
|
|
|
def lib_tracked_files
|
2020-05-15 08:31:12 -04:00
|
|
|
@lib_tracked_files ||= git_ls_files(lib_tracked_files_glob)
|
2020-05-08 01:19:04 -04:00
|
|
|
end
|
2019-12-14 05:49:16 -05:00
|
|
|
|
2020-05-08 01:19:04 -04:00
|
|
|
def man_tracked_files
|
2020-05-15 08:31:12 -04:00
|
|
|
@man_tracked_files ||= git_ls_files(man_tracked_files_glob)
|
2019-08-15 10:59:08 -04:00
|
|
|
end
|
|
|
|
|
2018-11-02 19:07:56 -04:00
|
|
|
def tmp(*path)
|
2020-05-15 08:31:12 -04:00
|
|
|
source_root.join("tmp", scope, *path)
|
2019-01-24 11:28:02 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
def scope
|
|
|
|
test_number = ENV["TEST_ENV_NUMBER"]
|
2019-08-18 23:51:19 -04:00
|
|
|
return "1" if test_number.nil?
|
2019-01-24 11:28:02 -05:00
|
|
|
|
|
|
|
test_number.empty? ? "1" : test_number
|
2018-11-02 19:07:56 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
def home(*path)
|
|
|
|
tmp.join("home", *path)
|
|
|
|
end
|
|
|
|
|
|
|
|
def default_bundle_path(*path)
|
2020-05-08 01:19:04 -04:00
|
|
|
if Bundler.feature_flag.default_install_uses_path?
|
|
|
|
local_gem_path(*path)
|
2018-11-02 19:07:56 -04:00
|
|
|
else
|
2020-05-08 01:19:04 -04:00
|
|
|
system_gem_path(*path)
|
2018-11-02 19:07:56 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def bundled_app(*path)
|
|
|
|
root = tmp.join("bundled_app")
|
|
|
|
FileUtils.mkdir_p(root)
|
|
|
|
root.join(*path)
|
|
|
|
end
|
|
|
|
|
|
|
|
def bundled_app2(*path)
|
|
|
|
root = tmp.join("bundled_app2")
|
|
|
|
FileUtils.mkdir_p(root)
|
|
|
|
root.join(*path)
|
|
|
|
end
|
|
|
|
|
|
|
|
def vendored_gems(path = nil)
|
2019-07-31 20:44:46 -04:00
|
|
|
bundled_app(*["vendor/bundle", Gem.ruby_engine, RbConfig::CONFIG["ruby_version"], path].compact)
|
2018-11-02 19:07:56 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
def cached_gem(path)
|
|
|
|
bundled_app("vendor/cache/#{path}.gem")
|
|
|
|
end
|
|
|
|
|
2020-05-08 01:19:04 -04:00
|
|
|
def bundled_app_gemfile
|
|
|
|
bundled_app("Gemfile")
|
|
|
|
end
|
|
|
|
|
|
|
|
def bundled_app_lock
|
|
|
|
bundled_app("Gemfile.lock")
|
|
|
|
end
|
|
|
|
|
2018-11-02 19:07:56 -04:00
|
|
|
def base_system_gems
|
|
|
|
tmp.join("gems/base")
|
|
|
|
end
|
|
|
|
|
2019-05-06 12:06:21 -04:00
|
|
|
def file_uri_for(path)
|
|
|
|
protocol = "file://"
|
2019-05-05 13:00:47 -04:00
|
|
|
root = Gem.win_platform? ? "/" : ""
|
2019-05-06 12:06:21 -04:00
|
|
|
|
2019-05-05 13:00:47 -04:00
|
|
|
protocol + root + path.to_s
|
2019-05-06 12:06:21 -04:00
|
|
|
end
|
|
|
|
|
2018-11-02 19:07:56 -04:00
|
|
|
def gem_repo1(*args)
|
|
|
|
tmp("gems/remote1", *args)
|
|
|
|
end
|
|
|
|
|
|
|
|
def gem_repo_missing(*args)
|
|
|
|
tmp("gems/missing", *args)
|
|
|
|
end
|
|
|
|
|
|
|
|
def gem_repo2(*args)
|
|
|
|
tmp("gems/remote2", *args)
|
|
|
|
end
|
|
|
|
|
|
|
|
def gem_repo3(*args)
|
|
|
|
tmp("gems/remote3", *args)
|
|
|
|
end
|
|
|
|
|
|
|
|
def gem_repo4(*args)
|
|
|
|
tmp("gems/remote4", *args)
|
|
|
|
end
|
|
|
|
|
|
|
|
def security_repo(*args)
|
|
|
|
tmp("gems/security_repo", *args)
|
|
|
|
end
|
|
|
|
|
|
|
|
def system_gem_path(*path)
|
|
|
|
tmp("gems/system", *path)
|
|
|
|
end
|
|
|
|
|
2020-05-15 08:31:12 -04:00
|
|
|
def pristine_system_gem_path
|
|
|
|
tmp("gems/base_system")
|
|
|
|
end
|
|
|
|
|
2020-05-08 01:19:04 -04:00
|
|
|
def local_gem_path(*path, base: bundled_app)
|
|
|
|
base.join(*[".bundle", Gem.ruby_engine, RbConfig::CONFIG["ruby_version"], *path].compact)
|
|
|
|
end
|
|
|
|
|
2018-11-02 19:07:56 -04:00
|
|
|
def lib_path(*args)
|
|
|
|
tmp("libs", *args)
|
|
|
|
end
|
|
|
|
|
2020-05-15 08:31:12 -04:00
|
|
|
def source_lib_dir
|
|
|
|
source_root.join("lib")
|
|
|
|
end
|
|
|
|
|
2019-11-11 03:57:45 -05:00
|
|
|
def lib_dir
|
2019-08-06 07:16:15 -04:00
|
|
|
root.join("lib")
|
|
|
|
end
|
|
|
|
|
2018-11-02 19:07:56 -04:00
|
|
|
def global_plugin_gem(*args)
|
|
|
|
home ".bundle", "plugin", "gems", *args
|
|
|
|
end
|
|
|
|
|
|
|
|
def local_plugin_gem(*args)
|
|
|
|
bundled_app ".bundle", "plugin", "gems", *args
|
|
|
|
end
|
|
|
|
|
|
|
|
def tmpdir(*args)
|
|
|
|
tmp "tmpdir", *args
|
|
|
|
end
|
|
|
|
|
2020-05-15 08:31:12 -04:00
|
|
|
def replace_version_file(version, dir: source_root)
|
2020-05-08 01:19:04 -04:00
|
|
|
version_file = File.expand_path("lib/bundler/version.rb", dir)
|
|
|
|
contents = File.read(version_file)
|
|
|
|
contents.sub!(/(^\s+VERSION\s*=\s*)"#{Gem::Version::VERSION_PATTERN}"/, %(\\1"#{version}"))
|
|
|
|
File.open(version_file, "w") {|f| f << contents }
|
2019-08-15 12:53:51 -04:00
|
|
|
end
|
|
|
|
|
2020-05-15 08:31:12 -04:00
|
|
|
def replace_build_metadata(build_metadata, dir: source_root)
|
|
|
|
build_metadata_file = File.expand_path("lib/bundler/build_metadata.rb", dir)
|
|
|
|
|
|
|
|
ivars = build_metadata.sort.map do |k, v|
|
|
|
|
" @#{k} = #{loaded_gemspec.send(:ruby_code, v)}"
|
|
|
|
end.join("\n")
|
|
|
|
|
|
|
|
contents = File.read(build_metadata_file)
|
|
|
|
contents.sub!(/^(\s+# begin ivars).+(^\s+# end ivars)/m, "\\1\n#{ivars}\n\\2")
|
|
|
|
File.open(build_metadata_file, "w") {|f| f << contents }
|
|
|
|
end
|
|
|
|
|
2018-11-02 19:07:56 -04:00
|
|
|
def ruby_core?
|
2019-08-15 10:47:18 -04:00
|
|
|
# avoid to warnings
|
2018-11-02 19:07:56 -04:00
|
|
|
@ruby_core ||= nil
|
|
|
|
|
|
|
|
if @ruby_core.nil?
|
Fix some bundler specs (#2380)
* These seem to consistenly pass already
* Show actual command when running `make test-bundler`
Current the setup command that installs the necessary gems for testing
bundler was printed, but not the actual command that runs the tests.
That was a bit confusing.
* Borrow trick from setproctitle specs
* A title that long doesn't get set sometimes
No idea why, but the test doesn't need that the title is that long.
* Fix most gem helper spec ruby-core failures
* Fix the rest of the gem helper failures
* Fix version spec by improving the assertion
* Remove unnecessary `BUNDLE_RUBY` environment var
We can use `RUBY` when necessary, and `BUNDLE_RUBY` is not a good name
because bundler considers `BUNDLE_*` variables as settings.
* Rename `BUNDLE_GEM` to `GEM_COMMAND`
This is more descriptive I think, and also friendlier for bundler
because `BUNDLE_` env variables are interpreted by bundler as settings,
and this is not a bundler setting.
This fixes one bundler spec failure in config specs against ruby-core.
* Fix quality spec when run in core
Use the proper path helper.
* Fix dummy lib builder to never load default gems
If a dummy library is named as a default gem, when requiring the library
from its executable, the default gem would be loaded when running from
core, because in core all default gems share path with bundler, and thus
they are always in the $LOAD_PATH. We fix the issue by loading lib
relatively inside dummy lib executables.
* More exact assertions
Sometimes I have the problem that I do some "print debugging" inside
specs, and suddently the spec passes. This happens when the assertion is
too relaxed, and the things I print make it match, specially when they
are simple strings like "1.0" than can be easily be part of gem paths
that I print for debugging.
I fix this by making a more exact assertion.
* Detect the correct shebang when ENV["RUBY"] is set
* Relax assertion
So that the spec passes even if another paths containing "ext" are in
the load path. This works to fix a ruby-core issue, but it's a better
assertion in general. We just want to know that the extension path was
added.
* Use folder structure independent path helper
It should fix this spec for ruby-core.
* Fix the last failing spec on ruby-core
* Skip `bundle open <default_gem>` spec when no default gems
2019-08-19 20:46:31 -04:00
|
|
|
@ruby_core = true & ENV["GEM_COMMAND"]
|
2018-11-02 19:07:56 -04:00
|
|
|
else
|
|
|
|
@ruby_core
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-05-25 14:32:23 -04:00
|
|
|
def git_commit_sha
|
|
|
|
ruby_core_tarball? ? "unknown" : sys_exec("git rev-parse --short HEAD", :dir => source_root).strip
|
|
|
|
end
|
|
|
|
|
2020-05-15 08:31:12 -04:00
|
|
|
private
|
|
|
|
|
|
|
|
def git_ls_files(glob)
|
2020-05-25 14:32:23 -04:00
|
|
|
skip "Not running on a git context, since running tests from a tarball" if ruby_core_tarball?
|
|
|
|
|
|
|
|
sys_exec!("git ls-files -z -- #{glob}", :dir => source_root).split("\x0")
|
2020-05-15 08:31:12 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
def tracked_files_glob
|
2020-05-27 06:51:09 -04:00
|
|
|
ruby_core? ? "lib/bundler lib/bundler.rb spec/bundler man/bundle*" : ""
|
2020-05-15 08:31:12 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
def lib_tracked_files_glob
|
|
|
|
ruby_core? ? "lib/bundler lib/bundler.rb" : "lib"
|
|
|
|
end
|
|
|
|
|
|
|
|
def man_tracked_files_glob
|
|
|
|
ruby_core? ? "man/bundle* man/gemfile*" : "man"
|
|
|
|
end
|
|
|
|
|
2020-05-25 14:32:23 -04:00
|
|
|
def git_root
|
|
|
|
ruby_core? ? source_root : source_root.parent
|
|
|
|
end
|
|
|
|
|
|
|
|
def ruby_core_tarball?
|
|
|
|
!git_root.join(".git").directory?
|
|
|
|
end
|
|
|
|
|
2018-11-02 19:07:56 -04:00
|
|
|
extend self
|
|
|
|
end
|
|
|
|
end
|