2018-11-02 19:07:56 -04:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2019-01-04 08:10:58 -05:00
|
|
|
RSpec.describe "major deprecations", :bundler => "< 3" do
|
2018-11-02 19:07:56 -04:00
|
|
|
let(:warnings) { last_command.bundler_err } # change to err in 2.0
|
|
|
|
let(:warnings_without_version_messages) { warnings.gsub(/#{Spec::Matchers::MAJOR_DEPRECATION}Bundler will only support ruby(gems)? >= .*/, "") }
|
|
|
|
|
|
|
|
context "in a .99 version" do
|
|
|
|
before do
|
|
|
|
simulate_bundler_version "1.99.1"
|
|
|
|
bundle "config --delete major_deprecations"
|
|
|
|
end
|
|
|
|
|
|
|
|
it "prints major deprecations without being configured" do
|
|
|
|
ruby <<-R
|
|
|
|
require "bundler"
|
|
|
|
Bundler::SharedHelpers.major_deprecation(Bundler::VERSION)
|
|
|
|
R
|
|
|
|
|
|
|
|
expect(warnings).to have_major_deprecation("1.99.1")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
before do
|
|
|
|
bundle "config major_deprecations true"
|
|
|
|
|
|
|
|
create_file "gems.rb", <<-G
|
|
|
|
source "file:#{gem_repo1}"
|
|
|
|
ruby #{RUBY_VERSION.dump}
|
|
|
|
gem "rack"
|
|
|
|
G
|
|
|
|
bundle! "install"
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "bundle_ruby" do
|
|
|
|
it "prints a deprecation" do
|
|
|
|
bundle_ruby
|
|
|
|
warnings.gsub! "\nruby #{RUBY_VERSION}", ""
|
|
|
|
expect(warnings).to have_major_deprecation "the bundle_ruby executable has been removed in favor of `bundle platform --ruby`"
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "Bundler" do
|
|
|
|
describe ".clean_env" do
|
|
|
|
it "is deprecated in favor of .original_env" do
|
|
|
|
source = "Bundler.clean_env"
|
|
|
|
bundle "exec ruby -e #{source.dump}"
|
|
|
|
expect(warnings).to have_major_deprecation "`Bundler.clean_env` has weird edge cases, use `.original_env` instead"
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe ".environment" do
|
|
|
|
it "is deprecated in favor of .load" do
|
|
|
|
source = "Bundler.environment"
|
|
|
|
bundle "exec ruby -e #{source.dump}"
|
|
|
|
expect(warnings).to have_major_deprecation "Bundler.environment has been removed in favor of Bundler.load"
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
shared_examples_for "environmental deprecations" do |trigger|
|
|
|
|
describe "ruby version", :ruby => "< 2.0" do
|
|
|
|
it "requires a newer ruby version" do
|
|
|
|
instance_eval(&trigger)
|
|
|
|
expect(warnings).to have_major_deprecation "Bundler will only support ruby >= 2.0, you are running #{RUBY_VERSION}"
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "rubygems version", :rubygems => "< 2.0" do
|
|
|
|
it "requires a newer rubygems version" do
|
|
|
|
instance_eval(&trigger)
|
|
|
|
expect(warnings).to have_major_deprecation "Bundler will only support rubygems >= 2.0, you are running #{Gem::VERSION}"
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "-rbundler/setup" do
|
|
|
|
it_behaves_like "environmental deprecations", proc { ruby "require 'bundler/setup'" }
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "Bundler.setup" do
|
|
|
|
it_behaves_like "environmental deprecations", proc { ruby "require 'bundler'; Bundler.setup" }
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "bundle check" do
|
|
|
|
it_behaves_like "environmental deprecations", proc { bundle :check }
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "bundle update --quiet" do
|
|
|
|
it "does not print any deprecations" do
|
|
|
|
bundle :update, :quiet => true
|
|
|
|
expect(warnings_without_version_messages).not_to have_major_deprecation
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "bundle update" do
|
|
|
|
before do
|
|
|
|
create_file("gems.rb", "")
|
|
|
|
bundle! "install"
|
|
|
|
end
|
|
|
|
|
|
|
|
it "warns when no options are given" do
|
|
|
|
bundle! "update"
|
|
|
|
expect(warnings).to have_major_deprecation a_string_including("Pass --all to `bundle update` to update everything")
|
|
|
|
end
|
|
|
|
|
|
|
|
it "does not warn when --all is passed" do
|
|
|
|
bundle! "update --all"
|
|
|
|
expect(warnings_without_version_messages).not_to have_major_deprecation
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "bundle install --binstubs" do
|
|
|
|
it "should output a deprecation warning" do
|
|
|
|
gemfile <<-G
|
|
|
|
gem 'rack'
|
|
|
|
G
|
|
|
|
|
|
|
|
bundle :install, :binstubs => true
|
|
|
|
expect(warnings).to have_major_deprecation a_string_including("The --binstubs option will be removed")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when bundle is run" do
|
|
|
|
it "should not warn about gems.rb" do
|
|
|
|
create_file "gems.rb", <<-G
|
|
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "rack"
|
|
|
|
G
|
|
|
|
|
|
|
|
bundle :install
|
|
|
|
expect(warnings_without_version_messages).not_to have_major_deprecation
|
|
|
|
end
|
|
|
|
|
|
|
|
it "should print a Gemfile deprecation warning" do
|
|
|
|
create_file "gems.rb"
|
|
|
|
install_gemfile! <<-G
|
|
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "rack"
|
|
|
|
G
|
|
|
|
expect(the_bundle).to include_gem "rack 1.0"
|
|
|
|
|
|
|
|
expect(warnings).to have_major_deprecation a_string_including("gems.rb and gems.locked will be preferred to Gemfile and Gemfile.lock.")
|
|
|
|
end
|
|
|
|
|
|
|
|
context "with flags" do
|
|
|
|
it "should print a deprecation warning about autoremembering flags" do
|
|
|
|
install_gemfile <<-G, :path => "vendor/bundle"
|
|
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "rack"
|
|
|
|
G
|
|
|
|
|
|
|
|
expect(warnings).to have_major_deprecation a_string_including(
|
|
|
|
"flags passed to commands will no longer be automatically remembered."
|
|
|
|
)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when Bundler.setup is run in a ruby script" do
|
|
|
|
it "should print a single deprecation warning" do
|
|
|
|
create_file "gems.rb"
|
|
|
|
install_gemfile! <<-G
|
|
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "rack", :group => :test
|
|
|
|
G
|
|
|
|
|
|
|
|
ruby <<-RUBY
|
|
|
|
require 'rubygems'
|
|
|
|
require 'bundler'
|
|
|
|
require 'bundler/vendored_thor'
|
|
|
|
|
|
|
|
Bundler.ui = Bundler::UI::Shell.new
|
|
|
|
Bundler.setup
|
|
|
|
Bundler.setup
|
|
|
|
RUBY
|
|
|
|
|
|
|
|
expect(warnings_without_version_messages).to have_major_deprecation("gems.rb and gems.locked will be preferred to Gemfile and Gemfile.lock.")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when `bundler/deployment` is required in a ruby script" do
|
|
|
|
it "should print a capistrano deprecation warning" do
|
|
|
|
ruby(<<-RUBY)
|
|
|
|
require 'bundler/deployment'
|
|
|
|
RUBY
|
|
|
|
|
|
|
|
expect(warnings).to have_major_deprecation("Bundler no longer integrates " \
|
|
|
|
"with Capistrano, but Capistrano provides " \
|
|
|
|
"its own integration with Bundler via the " \
|
|
|
|
"capistrano-bundler gem. Use it instead.")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe Bundler::Dsl do
|
|
|
|
before do
|
|
|
|
@rubygems = double("rubygems")
|
|
|
|
allow(Bundler::Source::Rubygems).to receive(:new) { @rubygems }
|
|
|
|
end
|
|
|
|
|
|
|
|
context "with github gems" do
|
|
|
|
it "warns about the https change" do
|
|
|
|
msg = <<-EOS
|
2019-01-04 08:10:58 -05:00
|
|
|
The :github git source is deprecated, and will be removed in Bundler 3.0. Change any "reponame" :github sources to "username/reponame". Add this code to the top of your Gemfile to ensure it continues to work:
|
2018-11-02 19:07:56 -04:00
|
|
|
|
|
|
|
git_source(:github) {|repo_name| "https://github.com/\#{repo_name}.git" }
|
|
|
|
|
|
|
|
EOS
|
2019-01-04 08:10:58 -05:00
|
|
|
expect(Bundler::SharedHelpers).to receive(:major_deprecation).with(3, msg)
|
2018-11-02 19:07:56 -04:00
|
|
|
subject.gem("sparks", :github => "indirect/sparks")
|
|
|
|
end
|
|
|
|
|
|
|
|
it "upgrades to https on request" do
|
|
|
|
Bundler.settings.temporary "github.https" => true
|
|
|
|
msg = <<-EOS
|
2019-01-04 08:10:58 -05:00
|
|
|
The :github git source is deprecated, and will be removed in Bundler 3.0. Change any "reponame" :github sources to "username/reponame". Add this code to the top of your Gemfile to ensure it continues to work:
|
2018-11-02 19:07:56 -04:00
|
|
|
|
|
|
|
git_source(:github) {|repo_name| "https://github.com/\#{repo_name}.git" }
|
|
|
|
|
|
|
|
EOS
|
2019-01-04 08:10:58 -05:00
|
|
|
expect(Bundler::SharedHelpers).to receive(:major_deprecation).with(3, msg)
|
|
|
|
expect(Bundler::SharedHelpers).to receive(:major_deprecation).with(3, "The `github.https` setting will be removed")
|
2018-11-02 19:07:56 -04:00
|
|
|
subject.gem("sparks", :github => "indirect/sparks")
|
|
|
|
github_uri = "https://github.com/indirect/sparks.git"
|
|
|
|
expect(subject.dependencies.first.source.uri).to eq(github_uri)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "with bitbucket gems" do
|
|
|
|
it "warns about removal" do
|
|
|
|
allow(Bundler.ui).to receive(:deprecate)
|
|
|
|
msg = <<-EOS
|
2019-01-04 08:10:58 -05:00
|
|
|
The :bitbucket git source is deprecated, and will be removed in Bundler 3.0. Add this code to the top of your Gemfile to ensure it continues to work:
|
2018-11-02 19:07:56 -04:00
|
|
|
|
|
|
|
git_source(:bitbucket) do |repo_name|
|
|
|
|
user_name, repo_name = repo_name.split("/")
|
|
|
|
repo_name ||= user_name
|
|
|
|
"https://\#{user_name}@bitbucket.org/\#{user_name}/\#{repo_name}.git"
|
|
|
|
end
|
|
|
|
|
|
|
|
EOS
|
2019-01-04 08:10:58 -05:00
|
|
|
expect(Bundler::SharedHelpers).to receive(:major_deprecation).with(3, msg)
|
2018-11-02 19:07:56 -04:00
|
|
|
subject.gem("not-really-a-gem", :bitbucket => "mcorp/flatlab-rails")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "with gist gems" do
|
|
|
|
it "warns about removal" do
|
|
|
|
allow(Bundler.ui).to receive(:deprecate)
|
|
|
|
msg = "The :gist git source is deprecated, and will be removed " \
|
2019-01-04 08:10:58 -05:00
|
|
|
"in Bundler 3.0. Add this code to the top of your Gemfile to ensure it " \
|
2018-11-02 19:07:56 -04:00
|
|
|
"continues to work:\n\n git_source(:gist) {|repo_name| " \
|
|
|
|
"\"https://gist.github.com/\#{repo_name}.git\" }\n\n"
|
2019-01-04 08:10:58 -05:00
|
|
|
expect(Bundler::SharedHelpers).to receive(:major_deprecation).with(3, msg)
|
2018-11-02 19:07:56 -04:00
|
|
|
subject.gem("not-really-a-gem", :gist => "1234")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "bundle show" do
|
|
|
|
it "prints a deprecation warning" do
|
|
|
|
install_gemfile! <<-G
|
|
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "rack"
|
|
|
|
G
|
|
|
|
|
|
|
|
bundle! :show
|
|
|
|
|
|
|
|
warnings.gsub!(/gems included.*?\[DEPRECATED/im, "[DEPRECATED")
|
|
|
|
|
|
|
|
expect(warnings).to have_major_deprecation a_string_including("use `bundle list` instead of `bundle show`")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "bundle console" do
|
|
|
|
it "prints a deprecation warning" do
|
|
|
|
bundle "console"
|
|
|
|
|
|
|
|
expect(warnings).to have_major_deprecation \
|
|
|
|
a_string_including("bundle console will be replaced by `bin/console` generated by `bundle gem <name>`")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|