2018-11-02 19:07:56 -04:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
RSpec.describe "bundle gem" do
|
2019-04-14 02:01:35 -04:00
|
|
|
def execute_bundle_gem(gem_name, flag = "")
|
2018-11-02 19:07:56 -04:00
|
|
|
bundle! "gem #{gem_name} #{flag}"
|
|
|
|
# reset gemspec cache for each test because of commit 3d4163a
|
|
|
|
Bundler.clear_gemspec_cache
|
|
|
|
end
|
|
|
|
|
|
|
|
def gem_skeleton_assertions(gem_name)
|
|
|
|
expect(bundled_app("#{gem_name}/#{gem_name}.gemspec")).to exist
|
|
|
|
expect(bundled_app("#{gem_name}/README.md")).to exist
|
|
|
|
expect(bundled_app("#{gem_name}/Gemfile")).to exist
|
|
|
|
expect(bundled_app("#{gem_name}/Rakefile")).to exist
|
|
|
|
expect(bundled_app("#{gem_name}/lib/test/gem.rb")).to exist
|
|
|
|
expect(bundled_app("#{gem_name}/lib/test/gem/version.rb")).to exist
|
|
|
|
end
|
|
|
|
|
2019-06-17 04:23:47 -04:00
|
|
|
let(:generated_gemspec) { Bundler::GemHelper.new(bundled_app(gem_name).to_s).gemspec }
|
2019-06-17 04:23:24 -04:00
|
|
|
|
2018-11-02 19:07:56 -04:00
|
|
|
before do
|
2019-06-01 05:49:40 -04:00
|
|
|
global_config "BUNDLE_GEM__MIT" => "false", "BUNDLE_GEM__TEST" => "false", "BUNDLE_GEM__COC" => "false"
|
2018-11-02 19:07:56 -04:00
|
|
|
git_config_content = <<-EOF
|
|
|
|
[user]
|
|
|
|
name = "Bundler User"
|
|
|
|
email = user@example.com
|
|
|
|
[github]
|
|
|
|
user = bundleuser
|
|
|
|
EOF
|
|
|
|
@git_config_location = ENV["GIT_CONFIG"]
|
|
|
|
path = "#{File.expand_path(tmp, File.dirname(__FILE__))}/test_git_config.txt"
|
|
|
|
File.open(path, "w") {|f| f.write(git_config_content) }
|
|
|
|
ENV["GIT_CONFIG"] = path
|
|
|
|
end
|
|
|
|
|
|
|
|
after do
|
|
|
|
FileUtils.rm(ENV["GIT_CONFIG"]) if File.exist?(ENV["GIT_CONFIG"])
|
|
|
|
ENV["GIT_CONFIG"] = @git_config_location
|
|
|
|
end
|
|
|
|
|
|
|
|
shared_examples_for "git config is present" do
|
|
|
|
context "git config user.{name,email} present" do
|
|
|
|
it "sets gemspec author to git user.name if available" do
|
2019-06-17 04:23:47 -04:00
|
|
|
expect(generated_gemspec.authors.first).to eq("Bundler User")
|
2018-11-02 19:07:56 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "sets gemspec email to git user.email if available" do
|
2019-06-17 04:23:47 -04:00
|
|
|
expect(generated_gemspec.email.first).to eq("user@example.com")
|
2018-11-02 19:07:56 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
shared_examples_for "git config is absent" do
|
|
|
|
it "sets gemspec author to default message if git user.name is not set or empty" do
|
2019-06-17 04:23:47 -04:00
|
|
|
expect(generated_gemspec.authors.first).to eq("TODO: Write your name")
|
2018-11-02 19:07:56 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "sets gemspec email to default message if git user.email is not set or empty" do
|
2019-06-17 04:23:47 -04:00
|
|
|
expect(generated_gemspec.email.first).to eq("TODO: Write your email address")
|
2018-11-02 19:07:56 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-07-24 06:24:55 -04:00
|
|
|
describe "git repo initialization" do
|
|
|
|
let(:gem_name) { "test-gem" }
|
|
|
|
|
|
|
|
shared_examples_for "a gem with an initial git repo" do
|
|
|
|
before do
|
|
|
|
execute_bundle_gem(gem_name, flags)
|
|
|
|
end
|
|
|
|
it "generates a gem skeleton with a .git folder" do
|
|
|
|
gem_skeleton_assertions(gem_name)
|
|
|
|
expect(bundled_app("test-gem/.git")).to exist
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when using the default" do
|
|
|
|
it_behaves_like "a gem with an initial git repo" do
|
|
|
|
let(:flags) { "" }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when explicitly passing --git" do
|
|
|
|
it_behaves_like "a gem with an initial git repo" do
|
|
|
|
let(:flags) { "--git" }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when passing --no-git" do
|
|
|
|
before do
|
|
|
|
execute_bundle_gem(gem_name, "--no-git")
|
|
|
|
end
|
|
|
|
it "generates a gem skeleton without a .git folder" do
|
|
|
|
gem_skeleton_assertions(gem_name)
|
|
|
|
expect(bundled_app("test-gem/.git")).not_to exist
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-11-02 19:07:56 -04:00
|
|
|
shared_examples_for "--mit flag" do
|
|
|
|
before do
|
|
|
|
execute_bundle_gem(gem_name, "--mit")
|
|
|
|
end
|
|
|
|
it "generates a gem skeleton with MIT license" do
|
|
|
|
gem_skeleton_assertions(gem_name)
|
|
|
|
expect(bundled_app("test-gem/LICENSE.txt")).to exist
|
|
|
|
skel = Bundler::GemHelper.new(bundled_app(gem_name).to_s)
|
|
|
|
expect(skel.gemspec.license).to eq("MIT")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
shared_examples_for "--no-mit flag" do
|
|
|
|
before do
|
|
|
|
execute_bundle_gem(gem_name, "--no-mit")
|
|
|
|
end
|
|
|
|
it "generates a gem skeleton without MIT license" do
|
|
|
|
gem_skeleton_assertions(gem_name)
|
|
|
|
expect(bundled_app("test-gem/LICENSE.txt")).to_not exist
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
shared_examples_for "--coc flag" do
|
|
|
|
before do
|
2019-04-14 02:01:35 -04:00
|
|
|
execute_bundle_gem(gem_name, "--coc")
|
2018-11-02 19:07:56 -04:00
|
|
|
end
|
|
|
|
it "generates a gem skeleton with MIT license" do
|
|
|
|
gem_skeleton_assertions(gem_name)
|
|
|
|
expect(bundled_app("test-gem/CODE_OF_CONDUCT.md")).to exist
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "README additions" do
|
|
|
|
it "generates the README with a section for the Code of Conduct" do
|
|
|
|
expect(bundled_app("test-gem/README.md").read).to include("## Code of Conduct")
|
|
|
|
expect(bundled_app("test-gem/README.md").read).to include("https://github.com/bundleuser/#{gem_name}/blob/master/CODE_OF_CONDUCT.md")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
shared_examples_for "--no-coc flag" do
|
|
|
|
before do
|
2019-04-14 02:01:35 -04:00
|
|
|
execute_bundle_gem(gem_name, "--no-coc")
|
2018-11-02 19:07:56 -04:00
|
|
|
end
|
|
|
|
it "generates a gem skeleton without Code of Conduct" do
|
|
|
|
gem_skeleton_assertions(gem_name)
|
|
|
|
expect(bundled_app("test-gem/CODE_OF_CONDUCT.md")).to_not exist
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "README additions" do
|
|
|
|
it "generates the README without a section for the Code of Conduct" do
|
|
|
|
expect(bundled_app("test-gem/README.md").read).not_to include("## Code of Conduct")
|
|
|
|
expect(bundled_app("test-gem/README.md").read).not_to include("https://github.com/bundleuser/#{gem_name}/blob/master/CODE_OF_CONDUCT.md")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "README.md" do
|
|
|
|
let(:gem_name) { "test_gem" }
|
|
|
|
|
|
|
|
context "git config github.user present" do
|
|
|
|
before do
|
|
|
|
execute_bundle_gem(gem_name)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "contribute URL set to git username" do
|
|
|
|
expect(bundled_app("test_gem/README.md").read).not_to include("[USERNAME]")
|
|
|
|
expect(bundled_app("test_gem/README.md").read).to include("github.com/bundleuser")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "git config github.user is absent" do
|
|
|
|
before do
|
|
|
|
sys_exec("git config --unset github.user")
|
|
|
|
in_app_root
|
|
|
|
bundle "gem #{gem_name}"
|
|
|
|
end
|
|
|
|
|
|
|
|
it "contribute URL set to [USERNAME]" do
|
|
|
|
expect(bundled_app("test_gem/README.md").read).to include("[USERNAME]")
|
|
|
|
expect(bundled_app("test_gem/README.md").read).not_to include("github.com/bundleuser")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
it "creates a new git repository" do
|
|
|
|
in_app_root
|
|
|
|
bundle "gem test_gem"
|
|
|
|
expect(bundled_app("test_gem/.git")).to exist
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when git is not available" do
|
|
|
|
let(:gem_name) { "test_gem" }
|
|
|
|
|
|
|
|
# This spec cannot have `git` available in the test env
|
|
|
|
before do
|
|
|
|
load_paths = [lib, spec]
|
|
|
|
load_path_str = "-I#{load_paths.join(File::PATH_SEPARATOR)}"
|
|
|
|
|
2019-04-14 02:01:35 -04:00
|
|
|
sys_exec "#{Gem.ruby} #{load_path_str} #{bindir.join("bundle")} gem #{gem_name}", "PATH" => ""
|
2018-11-02 19:07:56 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "creates the gem without the need for git" do
|
|
|
|
expect(bundled_app("#{gem_name}/README.md")).to exist
|
|
|
|
end
|
|
|
|
|
|
|
|
it "doesn't create a git repo" do
|
|
|
|
expect(bundled_app("#{gem_name}/.git")).to_not exist
|
|
|
|
end
|
|
|
|
|
|
|
|
it "doesn't create a .gitignore file" do
|
|
|
|
expect(bundled_app("#{gem_name}/.gitignore")).to_not exist
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
Fix some bundler specs (#2380)
* These seem to consistenly pass already
* Show actual command when running `make test-bundler`
Current the setup command that installs the necessary gems for testing
bundler was printed, but not the actual command that runs the tests.
That was a bit confusing.
* Borrow trick from setproctitle specs
* A title that long doesn't get set sometimes
No idea why, but the test doesn't need that the title is that long.
* Fix most gem helper spec ruby-core failures
* Fix the rest of the gem helper failures
* Fix version spec by improving the assertion
* Remove unnecessary `BUNDLE_RUBY` environment var
We can use `RUBY` when necessary, and `BUNDLE_RUBY` is not a good name
because bundler considers `BUNDLE_*` variables as settings.
* Rename `BUNDLE_GEM` to `GEM_COMMAND`
This is more descriptive I think, and also friendlier for bundler
because `BUNDLE_` env variables are interpreted by bundler as settings,
and this is not a bundler setting.
This fixes one bundler spec failure in config specs against ruby-core.
* Fix quality spec when run in core
Use the proper path helper.
* Fix dummy lib builder to never load default gems
If a dummy library is named as a default gem, when requiring the library
from its executable, the default gem would be loaded when running from
core, because in core all default gems share path with bundler, and thus
they are always in the $LOAD_PATH. We fix the issue by loading lib
relatively inside dummy lib executables.
* More exact assertions
Sometimes I have the problem that I do some "print debugging" inside
specs, and suddently the spec passes. This happens when the assertion is
too relaxed, and the things I print make it match, specially when they
are simple strings like "1.0" than can be easily be part of gem paths
that I print for debugging.
I fix this by making a more exact assertion.
* Detect the correct shebang when ENV["RUBY"] is set
* Relax assertion
So that the spec passes even if another paths containing "ext" are in
the load path. This works to fix a ruby-core issue, but it's a better
assertion in general. We just want to know that the extension path was
added.
* Use folder structure independent path helper
It should fix this spec for ruby-core.
* Fix the last failing spec on ruby-core
* Skip `bundle open <default_gem>` spec when no default gems
2019-08-19 20:46:31 -04:00
|
|
|
it "generates a valid gemspec" do
|
2018-11-02 19:07:56 -04:00
|
|
|
in_app_root
|
|
|
|
bundle! "gem newgem --bin"
|
|
|
|
|
2019-05-31 05:03:11 -04:00
|
|
|
prepare_gemspec(bundled_app("newgem", "newgem.gemspec"))
|
2018-11-02 19:07:56 -04:00
|
|
|
|
|
|
|
Dir.chdir(bundled_app("newgem")) do
|
2019-08-15 10:47:44 -04:00
|
|
|
gems = ["rake-12.3.2"]
|
2018-11-02 19:07:56 -04:00
|
|
|
system_gems gems, :path => :bundle_path
|
|
|
|
bundle! "exec rake build"
|
|
|
|
end
|
|
|
|
|
|
|
|
expect(last_command.stdboth).not_to include("ERROR")
|
|
|
|
end
|
|
|
|
|
|
|
|
context "gem naming with relative paths" do
|
|
|
|
before do
|
|
|
|
in_app_root
|
|
|
|
end
|
|
|
|
|
|
|
|
it "resolves ." do
|
|
|
|
create_temporary_dir("tmp")
|
|
|
|
|
|
|
|
bundle "gem ."
|
|
|
|
|
|
|
|
expect(bundled_app("tmp/lib/tmp.rb")).to exist
|
|
|
|
end
|
|
|
|
|
|
|
|
it "resolves .." do
|
|
|
|
create_temporary_dir("temp/empty_dir")
|
|
|
|
|
|
|
|
bundle "gem .."
|
|
|
|
|
|
|
|
expect(bundled_app("temp/lib/temp.rb")).to exist
|
|
|
|
end
|
|
|
|
|
|
|
|
it "resolves relative directory" do
|
|
|
|
create_temporary_dir("tmp/empty/tmp")
|
|
|
|
|
|
|
|
bundle "gem ../../empty"
|
|
|
|
|
|
|
|
expect(bundled_app("tmp/empty/lib/empty.rb")).to exist
|
|
|
|
end
|
|
|
|
|
|
|
|
def create_temporary_dir(dir)
|
|
|
|
FileUtils.mkdir_p(dir)
|
|
|
|
Dir.chdir(dir)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "gem naming with underscore" do
|
|
|
|
let(:gem_name) { "test_gem" }
|
|
|
|
|
|
|
|
before do
|
|
|
|
execute_bundle_gem(gem_name)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "generates a gem skeleton" do
|
|
|
|
expect(bundled_app("test_gem/test_gem.gemspec")).to exist
|
|
|
|
expect(bundled_app("test_gem/Gemfile")).to exist
|
|
|
|
expect(bundled_app("test_gem/Rakefile")).to exist
|
|
|
|
expect(bundled_app("test_gem/lib/test_gem.rb")).to exist
|
|
|
|
expect(bundled_app("test_gem/lib/test_gem/version.rb")).to exist
|
|
|
|
expect(bundled_app("test_gem/.gitignore")).to exist
|
|
|
|
|
|
|
|
expect(bundled_app("test_gem/bin/setup")).to exist
|
|
|
|
expect(bundled_app("test_gem/bin/console")).to exist
|
|
|
|
expect(bundled_app("test_gem/bin/setup")).to be_executable
|
|
|
|
expect(bundled_app("test_gem/bin/console")).to be_executable
|
|
|
|
end
|
|
|
|
|
|
|
|
it "starts with version 0.1.0" do
|
|
|
|
expect(bundled_app("test_gem/lib/test_gem/version.rb").read).to match(/VERSION = "0.1.0"/)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "does not nest constants" do
|
|
|
|
expect(bundled_app("test_gem/lib/test_gem/version.rb").read).to match(/module TestGem/)
|
|
|
|
expect(bundled_app("test_gem/lib/test_gem.rb").read).to match(/module TestGem/)
|
|
|
|
end
|
|
|
|
|
|
|
|
it_should_behave_like "git config is present"
|
|
|
|
|
|
|
|
context "git config user.{name,email} is not set" do
|
|
|
|
before do
|
|
|
|
`git config --unset user.name`
|
|
|
|
`git config --unset user.email`
|
|
|
|
in_app_root
|
|
|
|
bundle "gem #{gem_name}"
|
|
|
|
end
|
|
|
|
|
|
|
|
it_should_behave_like "git config is absent"
|
|
|
|
end
|
|
|
|
|
2019-04-14 02:01:35 -04:00
|
|
|
it "sets gemspec metadata['allowed_push_host']" do
|
2019-06-17 04:23:47 -04:00
|
|
|
expect(generated_gemspec.metadata["allowed_push_host"]).
|
2018-11-02 19:07:56 -04:00
|
|
|
to match(/mygemserver\.com/)
|
|
|
|
end
|
|
|
|
|
2016-03-26 06:47:43 -04:00
|
|
|
it "sets a minimum ruby version" do
|
2019-08-16 02:45:11 -04:00
|
|
|
bundler_gemspec = Bundler::GemHelper.new(gemspec_dir).gemspec
|
2016-03-26 06:47:43 -04:00
|
|
|
|
|
|
|
expect(bundler_gemspec.required_ruby_version).to eq(generated_gemspec.required_ruby_version)
|
|
|
|
end
|
|
|
|
|
2018-11-02 19:07:56 -04:00
|
|
|
it "requires the version file" do
|
|
|
|
expect(bundled_app("test_gem/lib/test_gem.rb").read).to match(%r{require "test_gem/version"})
|
|
|
|
end
|
|
|
|
|
|
|
|
it "creates a base error class" do
|
|
|
|
expect(bundled_app("test_gem/lib/test_gem.rb").read).to match(/class Error < StandardError; end$/)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "runs rake without problems" do
|
2019-04-14 02:01:35 -04:00
|
|
|
system_gems ["rake-12.3.2"]
|
2018-11-02 19:07:56 -04:00
|
|
|
|
|
|
|
rakefile = strip_whitespace <<-RAKEFILE
|
|
|
|
task :default do
|
|
|
|
puts 'SUCCESS'
|
|
|
|
end
|
|
|
|
RAKEFILE
|
|
|
|
File.open(bundled_app("test_gem/Rakefile"), "w") do |file|
|
|
|
|
file.puts rakefile
|
|
|
|
end
|
|
|
|
|
|
|
|
Dir.chdir(bundled_app(gem_name)) do
|
|
|
|
sys_exec(rake)
|
|
|
|
expect(out).to include("SUCCESS")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "--exe parameter set" do
|
|
|
|
before do
|
|
|
|
in_app_root
|
|
|
|
bundle "gem #{gem_name} --exe"
|
|
|
|
end
|
|
|
|
|
|
|
|
it "builds exe skeleton" do
|
|
|
|
expect(bundled_app("test_gem/exe/test_gem")).to exist
|
|
|
|
end
|
|
|
|
|
|
|
|
it "requires 'test-gem'" do
|
|
|
|
expect(bundled_app("test_gem/exe/test_gem").read).to match(/require "test_gem"/)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "--bin parameter set" do
|
|
|
|
before do
|
|
|
|
in_app_root
|
|
|
|
bundle "gem #{gem_name} --bin"
|
|
|
|
end
|
|
|
|
|
|
|
|
it "builds exe skeleton" do
|
|
|
|
expect(bundled_app("test_gem/exe/test_gem")).to exist
|
|
|
|
end
|
|
|
|
|
|
|
|
it "requires 'test-gem'" do
|
|
|
|
expect(bundled_app("test_gem/exe/test_gem").read).to match(/require "test_gem"/)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "no --test parameter" do
|
|
|
|
before do
|
|
|
|
in_app_root
|
|
|
|
bundle "gem #{gem_name}"
|
|
|
|
end
|
|
|
|
|
|
|
|
it "doesn't create any spec/test file" do
|
|
|
|
expect(bundled_app("test_gem/.rspec")).to_not exist
|
|
|
|
expect(bundled_app("test_gem/spec/test_gem_spec.rb")).to_not exist
|
|
|
|
expect(bundled_app("test_gem/spec/spec_helper.rb")).to_not exist
|
|
|
|
expect(bundled_app("test_gem/test/test_test_gem.rb")).to_not exist
|
|
|
|
expect(bundled_app("test_gem/test/minitest_helper.rb")).to_not exist
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "--test parameter set to rspec" do
|
|
|
|
before do
|
|
|
|
in_app_root
|
|
|
|
bundle "gem #{gem_name} --test=rspec"
|
|
|
|
end
|
|
|
|
|
|
|
|
it "builds spec skeleton" do
|
|
|
|
expect(bundled_app("test_gem/.rspec")).to exist
|
|
|
|
expect(bundled_app("test_gem/spec/test_gem_spec.rb")).to exist
|
|
|
|
expect(bundled_app("test_gem/spec/spec_helper.rb")).to exist
|
|
|
|
end
|
|
|
|
|
2019-06-26 10:35:49 -04:00
|
|
|
it "depends on a specific version of rspec in generated Gemfile" do
|
|
|
|
Dir.chdir(bundled_app("test_gem")) do
|
|
|
|
builder = Bundler::Dsl.new
|
|
|
|
builder.eval_gemfile(bundled_app("test_gem/Gemfile"))
|
|
|
|
builder.dependencies
|
|
|
|
rspec_dep = builder.dependencies.find {|d| d.name == "rspec" }
|
|
|
|
expect(rspec_dep).to be_specific
|
|
|
|
end
|
2018-11-02 19:07:56 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "requires 'test-gem'" do
|
|
|
|
expect(bundled_app("test_gem/spec/spec_helper.rb").read).to include(%(require "test_gem"))
|
|
|
|
end
|
|
|
|
|
|
|
|
it "creates a default test which fails" do
|
|
|
|
expect(bundled_app("test_gem/spec/test_gem_spec.rb").read).to include("expect(false).to eq(true)")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "gem.test setting set to rspec" do
|
|
|
|
before do
|
|
|
|
in_app_root
|
2019-04-14 02:01:35 -04:00
|
|
|
bundle "config set gem.test rspec"
|
2018-11-02 19:07:56 -04:00
|
|
|
bundle "gem #{gem_name}"
|
|
|
|
end
|
|
|
|
|
|
|
|
it "builds spec skeleton" do
|
|
|
|
expect(bundled_app("test_gem/.rspec")).to exist
|
|
|
|
expect(bundled_app("test_gem/spec/test_gem_spec.rb")).to exist
|
|
|
|
expect(bundled_app("test_gem/spec/spec_helper.rb")).to exist
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "gem.test setting set to rspec and --test is set to minitest" do
|
|
|
|
before do
|
|
|
|
in_app_root
|
2019-04-14 02:01:35 -04:00
|
|
|
bundle "config set gem.test rspec"
|
2018-11-02 19:07:56 -04:00
|
|
|
bundle "gem #{gem_name} --test=minitest"
|
|
|
|
end
|
|
|
|
|
|
|
|
it "builds spec skeleton" do
|
|
|
|
expect(bundled_app("test_gem/test/test_gem_test.rb")).to exist
|
|
|
|
expect(bundled_app("test_gem/test/test_helper.rb")).to exist
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "--test parameter set to minitest" do
|
|
|
|
before do
|
|
|
|
in_app_root
|
|
|
|
bundle "gem #{gem_name} --test=minitest"
|
|
|
|
end
|
|
|
|
|
2019-04-14 02:01:35 -04:00
|
|
|
it "depends on a specific version of minitest" do
|
2019-06-26 10:35:49 -04:00
|
|
|
Dir.chdir(bundled_app("test_gem")) do
|
|
|
|
builder = Bundler::Dsl.new
|
|
|
|
builder.eval_gemfile(bundled_app("test_gem/Gemfile"))
|
|
|
|
builder.dependencies
|
|
|
|
minitest_dep = builder.dependencies.find {|d| d.name == "minitest" }
|
|
|
|
expect(minitest_dep).to be_specific
|
|
|
|
end
|
2018-11-02 19:07:56 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "builds spec skeleton" do
|
|
|
|
expect(bundled_app("test_gem/test/test_gem_test.rb")).to exist
|
|
|
|
expect(bundled_app("test_gem/test/test_helper.rb")).to exist
|
|
|
|
end
|
|
|
|
|
|
|
|
it "requires 'test-gem'" do
|
|
|
|
expect(bundled_app("test_gem/test/test_helper.rb").read).to include(%(require "test_gem"))
|
|
|
|
end
|
|
|
|
|
|
|
|
it "requires 'minitest_helper'" do
|
|
|
|
expect(bundled_app("test_gem/test/test_gem_test.rb").read).to include(%(require "test_helper"))
|
|
|
|
end
|
|
|
|
|
|
|
|
it "creates a default test which fails" do
|
|
|
|
expect(bundled_app("test_gem/test/test_gem_test.rb").read).to include("assert false")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "gem.test setting set to minitest" do
|
|
|
|
before do
|
|
|
|
in_app_root
|
2019-04-14 02:01:35 -04:00
|
|
|
bundle "config set gem.test minitest"
|
2018-11-02 19:07:56 -04:00
|
|
|
bundle "gem #{gem_name}"
|
|
|
|
end
|
|
|
|
|
|
|
|
it "creates a default rake task to run the test suite" do
|
|
|
|
rakefile = strip_whitespace <<-RAKEFILE
|
|
|
|
require "bundler/gem_tasks"
|
|
|
|
require "rake/testtask"
|
|
|
|
|
|
|
|
Rake::TestTask.new(:test) do |t|
|
|
|
|
t.libs << "test"
|
|
|
|
t.libs << "lib"
|
|
|
|
t.test_files = FileList["test/**/*_test.rb"]
|
|
|
|
end
|
|
|
|
|
|
|
|
task :default => :test
|
|
|
|
RAKEFILE
|
|
|
|
|
|
|
|
expect(bundled_app("test_gem/Rakefile").read).to eq(rakefile)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "--test with no arguments" do
|
|
|
|
before do
|
|
|
|
in_app_root
|
|
|
|
bundle "gem #{gem_name} --test"
|
|
|
|
end
|
|
|
|
|
|
|
|
it "defaults to rspec" do
|
|
|
|
expect(bundled_app("test_gem/spec/spec_helper.rb")).to exist
|
|
|
|
expect(bundled_app("test_gem/test/minitest_helper.rb")).to_not exist
|
|
|
|
end
|
|
|
|
|
|
|
|
it "creates a .travis.yml file to test the library against the current Ruby version on Travis CI" do
|
|
|
|
expect(bundled_app("test_gem/.travis.yml").read).to match(/- #{RUBY_VERSION}/)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "--edit option" do
|
|
|
|
it "opens the generated gemspec in the user's text editor" do
|
|
|
|
in_app_root
|
|
|
|
output = bundle "gem #{gem_name} --edit=echo"
|
|
|
|
gemspec_path = File.join(Dir.pwd, gem_name, "#{gem_name}.gemspec")
|
|
|
|
expect(output).to include("echo \"#{gemspec_path}\"")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "testing --mit and --coc options against bundle config settings" do
|
|
|
|
let(:gem_name) { "test-gem" }
|
|
|
|
|
|
|
|
context "with mit option in bundle config settings set to true" do
|
|
|
|
before do
|
|
|
|
global_config "BUNDLE_GEM__MIT" => "true", "BUNDLE_GEM__TEST" => "false", "BUNDLE_GEM__COC" => "false"
|
|
|
|
end
|
|
|
|
it_behaves_like "--mit flag"
|
|
|
|
it_behaves_like "--no-mit flag"
|
|
|
|
end
|
|
|
|
|
|
|
|
context "with mit option in bundle config settings set to false" do
|
|
|
|
it_behaves_like "--mit flag"
|
|
|
|
it_behaves_like "--no-mit flag"
|
|
|
|
end
|
|
|
|
|
|
|
|
context "with coc option in bundle config settings set to true" do
|
|
|
|
before do
|
|
|
|
global_config "BUNDLE_GEM__MIT" => "false", "BUNDLE_GEM__TEST" => "false", "BUNDLE_GEM__COC" => "true"
|
|
|
|
end
|
|
|
|
it_behaves_like "--coc flag"
|
|
|
|
it_behaves_like "--no-coc flag"
|
|
|
|
end
|
|
|
|
|
|
|
|
context "with coc option in bundle config settings set to false" do
|
|
|
|
it_behaves_like "--coc flag"
|
|
|
|
it_behaves_like "--no-coc flag"
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "gem naming with dashed" do
|
|
|
|
let(:gem_name) { "test-gem" }
|
|
|
|
|
|
|
|
before do
|
|
|
|
execute_bundle_gem(gem_name)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "generates a gem skeleton" do
|
|
|
|
expect(bundled_app("test-gem/test-gem.gemspec")).to exist
|
|
|
|
expect(bundled_app("test-gem/Gemfile")).to exist
|
|
|
|
expect(bundled_app("test-gem/Rakefile")).to exist
|
|
|
|
expect(bundled_app("test-gem/lib/test/gem.rb")).to exist
|
|
|
|
expect(bundled_app("test-gem/lib/test/gem/version.rb")).to exist
|
|
|
|
end
|
|
|
|
|
|
|
|
it "starts with version 0.1.0" do
|
|
|
|
expect(bundled_app("test-gem/lib/test/gem/version.rb").read).to match(/VERSION = "0.1.0"/)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "nests constants so they work" do
|
|
|
|
expect(bundled_app("test-gem/lib/test/gem/version.rb").read).to match(/module Test\n module Gem/)
|
|
|
|
expect(bundled_app("test-gem/lib/test/gem.rb").read).to match(/module Test\n module Gem/)
|
|
|
|
end
|
|
|
|
|
|
|
|
it_should_behave_like "git config is present"
|
|
|
|
|
|
|
|
context "git config user.{name,email} is not set" do
|
|
|
|
before do
|
|
|
|
`git config --unset user.name`
|
|
|
|
`git config --unset user.email`
|
|
|
|
in_app_root
|
|
|
|
bundle "gem #{gem_name}"
|
|
|
|
end
|
|
|
|
|
|
|
|
it_should_behave_like "git config is absent"
|
|
|
|
end
|
|
|
|
|
|
|
|
it "requires the version file" do
|
|
|
|
expect(bundled_app("test-gem/lib/test/gem.rb").read).to match(%r{require "test/gem/version"})
|
|
|
|
end
|
|
|
|
|
|
|
|
it "runs rake without problems" do
|
2019-04-14 02:01:35 -04:00
|
|
|
system_gems ["rake-12.3.2"]
|
2018-11-02 19:07:56 -04:00
|
|
|
|
|
|
|
rakefile = strip_whitespace <<-RAKEFILE
|
|
|
|
task :default do
|
|
|
|
puts 'SUCCESS'
|
|
|
|
end
|
|
|
|
RAKEFILE
|
|
|
|
File.open(bundled_app("test-gem/Rakefile"), "w") do |file|
|
|
|
|
file.puts rakefile
|
|
|
|
end
|
|
|
|
|
|
|
|
Dir.chdir(bundled_app(gem_name)) do
|
|
|
|
sys_exec(rake)
|
|
|
|
expect(out).to include("SUCCESS")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "--bin parameter set" do
|
|
|
|
before do
|
|
|
|
in_app_root
|
|
|
|
bundle "gem #{gem_name} --bin"
|
|
|
|
end
|
|
|
|
|
|
|
|
it "builds bin skeleton" do
|
|
|
|
expect(bundled_app("test-gem/exe/test-gem")).to exist
|
|
|
|
end
|
|
|
|
|
|
|
|
it "requires 'test/gem'" do
|
|
|
|
expect(bundled_app("test-gem/exe/test-gem").read).to match(%r{require "test/gem"})
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "no --test parameter" do
|
|
|
|
before do
|
|
|
|
in_app_root
|
|
|
|
bundle "gem #{gem_name}"
|
|
|
|
end
|
|
|
|
|
|
|
|
it "doesn't create any spec/test file" do
|
|
|
|
expect(bundled_app("test-gem/.rspec")).to_not exist
|
|
|
|
expect(bundled_app("test-gem/spec/test/gem_spec.rb")).to_not exist
|
|
|
|
expect(bundled_app("test-gem/spec/spec_helper.rb")).to_not exist
|
|
|
|
expect(bundled_app("test-gem/test/test_test/gem.rb")).to_not exist
|
|
|
|
expect(bundled_app("test-gem/test/minitest_helper.rb")).to_not exist
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "--test parameter set to rspec" do
|
|
|
|
before do
|
|
|
|
in_app_root
|
|
|
|
bundle "gem #{gem_name} --test=rspec"
|
|
|
|
end
|
|
|
|
|
|
|
|
it "builds spec skeleton" do
|
|
|
|
expect(bundled_app("test-gem/.rspec")).to exist
|
|
|
|
expect(bundled_app("test-gem/spec/test/gem_spec.rb")).to exist
|
|
|
|
expect(bundled_app("test-gem/spec/spec_helper.rb")).to exist
|
|
|
|
end
|
|
|
|
|
|
|
|
it "requires 'test/gem'" do
|
|
|
|
expect(bundled_app("test-gem/spec/spec_helper.rb").read).to include(%(require "test/gem"))
|
|
|
|
end
|
|
|
|
|
|
|
|
it "creates a default test which fails" do
|
|
|
|
expect(bundled_app("test-gem/spec/test/gem_spec.rb").read).to include("expect(false).to eq(true)")
|
|
|
|
end
|
|
|
|
|
|
|
|
it "creates a default rake task to run the specs" do
|
|
|
|
rakefile = strip_whitespace <<-RAKEFILE
|
|
|
|
require "bundler/gem_tasks"
|
|
|
|
require "rspec/core/rake_task"
|
|
|
|
|
|
|
|
RSpec::Core::RakeTask.new(:spec)
|
|
|
|
|
|
|
|
task :default => :spec
|
|
|
|
RAKEFILE
|
|
|
|
|
|
|
|
expect(bundled_app("test-gem/Rakefile").read).to eq(rakefile)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "--test parameter set to minitest" do
|
|
|
|
before do
|
|
|
|
in_app_root
|
|
|
|
bundle "gem #{gem_name} --test=minitest"
|
|
|
|
end
|
|
|
|
|
|
|
|
it "builds spec skeleton" do
|
|
|
|
expect(bundled_app("test-gem/test/test/gem_test.rb")).to exist
|
|
|
|
expect(bundled_app("test-gem/test/test_helper.rb")).to exist
|
|
|
|
end
|
|
|
|
|
|
|
|
it "requires 'test/gem'" do
|
|
|
|
expect(bundled_app("test-gem/test/test_helper.rb").read).to match(%r{require "test/gem"})
|
|
|
|
end
|
|
|
|
|
|
|
|
it "requires 'test_helper'" do
|
|
|
|
expect(bundled_app("test-gem/test/test/gem_test.rb").read).to match(/require "test_helper"/)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "creates a default test which fails" do
|
|
|
|
expect(bundled_app("test-gem/test/test/gem_test.rb").read).to match(/assert false/)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "creates a default rake task to run the test suite" do
|
|
|
|
rakefile = strip_whitespace <<-RAKEFILE
|
|
|
|
require "bundler/gem_tasks"
|
|
|
|
require "rake/testtask"
|
|
|
|
|
|
|
|
Rake::TestTask.new(:test) do |t|
|
|
|
|
t.libs << "test"
|
|
|
|
t.libs << "lib"
|
|
|
|
t.test_files = FileList["test/**/*_test.rb"]
|
|
|
|
end
|
|
|
|
|
|
|
|
task :default => :test
|
|
|
|
RAKEFILE
|
|
|
|
|
|
|
|
expect(bundled_app("test-gem/Rakefile").read).to eq(rakefile)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "--test with no arguments" do
|
|
|
|
before do
|
|
|
|
in_app_root
|
|
|
|
bundle "gem #{gem_name} --test"
|
|
|
|
end
|
|
|
|
|
|
|
|
it "defaults to rspec" do
|
|
|
|
expect(bundled_app("test-gem/spec/spec_helper.rb")).to exist
|
|
|
|
expect(bundled_app("test-gem/test/minitest_helper.rb")).to_not exist
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "--ext parameter set" do
|
|
|
|
before do
|
|
|
|
in_app_root
|
|
|
|
bundle "gem test_gem --ext"
|
|
|
|
end
|
|
|
|
|
|
|
|
it "builds ext skeleton" do
|
|
|
|
expect(bundled_app("test_gem/ext/test_gem/extconf.rb")).to exist
|
|
|
|
expect(bundled_app("test_gem/ext/test_gem/test_gem.h")).to exist
|
|
|
|
expect(bundled_app("test_gem/ext/test_gem/test_gem.c")).to exist
|
|
|
|
end
|
|
|
|
|
|
|
|
it "includes rake-compiler" do
|
2019-06-26 10:35:49 -04:00
|
|
|
expect(bundled_app("test_gem/Gemfile").read).to include('gem "rake-compiler"')
|
2018-11-02 19:07:56 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "depends on compile task for build" do
|
|
|
|
rakefile = strip_whitespace <<-RAKEFILE
|
|
|
|
require "bundler/gem_tasks"
|
|
|
|
require "rake/extensiontask"
|
|
|
|
|
|
|
|
task :build => :compile
|
|
|
|
|
|
|
|
Rake::ExtensionTask.new("test_gem") do |ext|
|
|
|
|
ext.lib_dir = "lib/test_gem"
|
|
|
|
end
|
|
|
|
|
|
|
|
task :default => [:clobber, :compile, :spec]
|
|
|
|
RAKEFILE
|
|
|
|
|
|
|
|
expect(bundled_app("test_gem/Rakefile").read).to eq(rakefile)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "uncommon gem names" do
|
|
|
|
it "can deal with two dashes" do
|
2019-03-19 12:08:17 -04:00
|
|
|
execute_bundle_gem("a--a")
|
2018-11-02 19:07:56 -04:00
|
|
|
|
|
|
|
expect(bundled_app("a--a/a--a.gemspec")).to exist
|
|
|
|
end
|
|
|
|
|
|
|
|
it "fails gracefully with a ." do
|
|
|
|
bundle "gem foo.gemspec"
|
2019-06-01 05:49:40 -04:00
|
|
|
expect(err).to end_with("Invalid gem name foo.gemspec -- `Foo.gemspec` is an invalid constant name")
|
2018-11-02 19:07:56 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "fails gracefully with a ^" do
|
|
|
|
bundle "gem ^"
|
2019-06-01 05:49:40 -04:00
|
|
|
expect(err).to end_with("Invalid gem name ^ -- `^` is an invalid constant name")
|
2018-11-02 19:07:56 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "fails gracefully with a space" do
|
|
|
|
bundle "gem 'foo bar'"
|
2019-06-01 05:49:40 -04:00
|
|
|
expect(err).to end_with("Invalid gem name foo bar -- `Foo bar` is an invalid constant name")
|
2018-11-02 19:07:56 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "fails gracefully when multiple names are passed" do
|
|
|
|
bundle "gem foo bar baz"
|
2019-06-01 05:49:40 -04:00
|
|
|
expect(err).to eq(<<-E.strip)
|
2018-11-02 19:07:56 -04:00
|
|
|
ERROR: "bundle gem" was called with arguments ["foo", "bar", "baz"]
|
|
|
|
Usage: "bundle gem NAME [OPTIONS]"
|
|
|
|
E
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "#ensure_safe_gem_name" do
|
|
|
|
before do
|
|
|
|
bundle "gem #{subject}"
|
|
|
|
end
|
|
|
|
after do
|
|
|
|
Bundler.clear_gemspec_cache
|
|
|
|
end
|
|
|
|
|
|
|
|
context "with an existing const name" do
|
|
|
|
subject { "gem" }
|
2019-04-14 02:01:35 -04:00
|
|
|
it { expect(err).to include("Invalid gem name #{subject}") }
|
2018-11-02 19:07:56 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
context "with an existing hyphenated const name" do
|
|
|
|
subject { "gem-specification" }
|
2019-04-14 02:01:35 -04:00
|
|
|
it { expect(err).to include("Invalid gem name #{subject}") }
|
2018-11-02 19:07:56 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
context "starting with an existing const name" do
|
|
|
|
subject { "gem-somenewconstantname" }
|
2019-04-14 02:01:35 -04:00
|
|
|
it { expect(err).not_to include("Invalid gem name #{subject}") }
|
2018-11-02 19:07:56 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
context "ending with an existing const name" do
|
|
|
|
subject { "somenewconstantname-gem" }
|
2019-04-14 02:01:35 -04:00
|
|
|
it { expect(err).not_to include("Invalid gem name #{subject}") }
|
2018-11-02 19:07:56 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "on first run" do
|
|
|
|
before do
|
|
|
|
in_app_root
|
|
|
|
end
|
|
|
|
|
|
|
|
it "asks about test framework" do
|
|
|
|
global_config "BUNDLE_GEM__MIT" => "false", "BUNDLE_GEM__COC" => "false"
|
|
|
|
|
|
|
|
bundle "gem foobar" do |input, _, _|
|
|
|
|
input.puts "rspec"
|
|
|
|
end
|
|
|
|
|
|
|
|
expect(bundled_app("foobar/spec/spec_helper.rb")).to exist
|
|
|
|
rakefile = strip_whitespace <<-RAKEFILE
|
|
|
|
require "bundler/gem_tasks"
|
|
|
|
require "rspec/core/rake_task"
|
|
|
|
|
|
|
|
RSpec::Core::RakeTask.new(:spec)
|
|
|
|
|
|
|
|
task :default => :spec
|
|
|
|
RAKEFILE
|
|
|
|
|
|
|
|
expect(bundled_app("foobar/Rakefile").read).to eq(rakefile)
|
2019-06-26 10:35:49 -04:00
|
|
|
expect(bundled_app("foobar/Gemfile").read).to include('gem "rspec"')
|
2018-11-02 19:07:56 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "asks about MIT license" do
|
|
|
|
global_config "BUNDLE_GEM__TEST" => "false", "BUNDLE_GEM__COC" => "false"
|
|
|
|
|
2019-04-14 02:01:35 -04:00
|
|
|
bundle "config list"
|
2018-11-02 19:07:56 -04:00
|
|
|
|
|
|
|
bundle "gem foobar" do |input, _, _|
|
|
|
|
input.puts "yes"
|
|
|
|
end
|
|
|
|
|
|
|
|
expect(bundled_app("foobar/LICENSE.txt")).to exist
|
|
|
|
end
|
|
|
|
|
|
|
|
it "asks about CoC" do
|
|
|
|
global_config "BUNDLE_GEM__MIT" => "false", "BUNDLE_GEM__TEST" => "false"
|
|
|
|
|
|
|
|
bundle "gem foobar" do |input, _, _|
|
|
|
|
input.puts "yes"
|
|
|
|
end
|
|
|
|
|
|
|
|
expect(bundled_app("foobar/CODE_OF_CONDUCT.md")).to exist
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "on conflicts with a previously created file" do
|
|
|
|
it "should fail gracefully" do
|
|
|
|
in_app_root do
|
|
|
|
FileUtils.touch("conflict-foobar")
|
|
|
|
end
|
|
|
|
bundle "gem conflict-foobar"
|
2019-06-01 05:49:40 -04:00
|
|
|
expect(err).to include("Errno::ENOTDIR")
|
2018-11-02 19:07:56 -04:00
|
|
|
expect(exitstatus).to eql(32) if exitstatus
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "on conflicts with a previously created directory" do
|
|
|
|
it "should succeed" do
|
|
|
|
in_app_root do
|
|
|
|
FileUtils.mkdir_p("conflict-foobar/Gemfile")
|
|
|
|
end
|
|
|
|
bundle! "gem conflict-foobar"
|
2019-06-01 05:49:40 -04:00
|
|
|
expect(out).to include("file_clash conflict-foobar/Gemfile").
|
2018-11-02 19:07:56 -04:00
|
|
|
and include "Initializing git repo in #{bundled_app("conflict-foobar")}"
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|