From 085d0e5ccb7cecb1f761c1d3c72caeeedafc7d04 Mon Sep 17 00:00:00 2001 From: Yusuke Endoh Date: Sun, 14 Jul 2019 21:56:39 +0900 Subject: [PATCH] ruby.c (name_match_p): remove unnecessary condition It always returns immediately when len was decremented to zero. So len is always positive. This change will suppress Coverity Scan warning. --- ruby.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/ruby.c b/ruby.c index c32055a203..2610cf2387 100644 --- a/ruby.c +++ b/ruby.c @@ -834,7 +834,7 @@ static int name_match_p(const char *name, const char *str, size_t len) { if (len == 0) return 0; - do { + while (1) { while (TOLOWER(*str) == *name) { if (!--len || !*++str) return 1; ++name; @@ -844,8 +844,7 @@ name_match_p(const char *name, const char *str, size_t len) if (*name != '-' && *name != '_') return 0; ++name; ++str; - } while (len > 0); - return !*name; + } } #define NAME_MATCH_P(name, str, len) \