kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

Use omit instead of skip

Browse source
This commit is contained in:
aycabta 2019-12-03 12:46:55 +09:00
parent f09c1cf0e9
commit 0d3e4b8a79
1 changed files with 24 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

48
test/readline/test_readline.rb
View file

@ -27,7 +27,7 @@ module BasetestReadline
end end
def test_readline def test_readline
skip "Skip Editline" if /EditLine/n.match(Readline::VERSION) omit "Skip Editline" if /EditLine/n.match(Readline::VERSION)
with_temp_stdio do |stdin, stdout| with_temp_stdio do |stdin, stdout|
stdin.write("hello\n") stdin.write("hello\n")
stdin.close stdin.close
@ -65,8 +65,8 @@ module BasetestReadline
# line_buffer # line_buffer
# point # point
def test_line_buffer__point def test_line_buffer__point
skip "Skip Editline" if /EditLine/n.match(Readline::VERSION) omit "Skip Editline" if /EditLine/n.match(Readline::VERSION)
skip "GNU Readline has special behaviors" if defined?(Reline) and Readline == Reline omit "GNU Readline has special behaviors" if defined?(Reline) and Readline == Reline
begin begin
Readline.line_buffer Readline.line_buffer
Readline.point Readline.point
@ -154,7 +154,7 @@ module BasetestReadline
end end
def test_completion_proc_empty_result def test_completion_proc_empty_result
skip "Skip Editline" if /EditLine/n.match(Readline::VERSION) omit "Skip Editline" if /EditLine/n.match(Readline::VERSION)
with_temp_stdio do |stdin, stdout| with_temp_stdio do |stdin, stdout|
stdin.write("first\t") stdin.write("first\t")
stdin.flush stdin.flush
@ -233,7 +233,7 @@ module BasetestReadline
end end
def test_completion_encoding def test_completion_encoding
skip "Skip Editline" if /EditLine/n.match(Readline::VERSION) omit "Skip Editline" if /EditLine/n.match(Readline::VERSION)
bug5941 = '[Bug #5941]' bug5941 = '[Bug #5941]'
append_character = Readline.completion_append_character append_character = Readline.completion_append_character
Readline.completion_append_character = "" Readline.completion_append_character = ""
@ -261,7 +261,7 @@ module BasetestReadline
end or end or
begin begin
return if assert_under_utf8 return if assert_under_utf8
skip("missing test for locale #{locale.name}") omit("missing test for locale #{locale.name}")
end end
expected = results[0][0...1] expected = results[0][0...1]
Readline.completion_case_fold = false Readline.completion_case_fold = false
@ -335,7 +335,7 @@ module BasetestReadline
end end
def test_point def test_point
skip "Skip Editline" if /EditLine/n.match(Readline::VERSION) omit "Skip Editline" if /EditLine/n.match(Readline::VERSION)
assert_equal(0, Readline.point) assert_equal(0, Readline.point)
Readline.insert_text('12345') Readline.insert_text('12345')
assert_equal(5, Readline.point) assert_equal(5, Readline.point)
@ -350,7 +350,7 @@ module BasetestReadline
end end
def test_insert_text def test_insert_text
skip "Skip Editline" if /EditLine/n.match(Readline::VERSION) omit "Skip Editline" if /EditLine/n.match(Readline::VERSION)
str = "test_insert_text" str = "test_insert_text"
assert_equal(0, Readline.point) assert_equal(0, Readline.point)
assert_equal(Readline, Readline.insert_text(str)) assert_equal(Readline, Readline.insert_text(str))
@ -381,7 +381,7 @@ module BasetestReadline
end end
def test_delete_text def test_delete_text
skip "Skip Editline" if /EditLine/n.match(Readline::VERSION) omit "Skip Editline" if /EditLine/n.match(Readline::VERSION)
str = "test_insert_text" str = "test_insert_text"
assert_equal(0, Readline.point) assert_equal(0, Readline.point)
assert_equal(Readline, Readline.insert_text(str)) assert_equal(Readline, Readline.insert_text(str))
@ -401,7 +401,7 @@ module BasetestReadline
end end
def test_modify_text_in_pre_input_hook def test_modify_text_in_pre_input_hook
skip "Skip Editline" if /EditLine/n.match(Readline::VERSION) omit "Skip Editline" if /EditLine/n.match(Readline::VERSION)
with_temp_stdio {|stdin, stdout| with_temp_stdio {|stdin, stdout|
begin begin
stdin.write("world\n") stdin.write("world\n")
@ -432,10 +432,10 @@ module BasetestReadline
end end
def test_input_metachar def test_input_metachar
skip "Skip Editline" if /EditLine/n.match(Readline::VERSION) omit "Skip Editline" if /EditLine/n.match(Readline::VERSION)
# test will pass on Windows reline, but not readline # test will pass on Windows reline, but not readline
skip "Won't pass on mingw readline.so using 8.0.001" if /mingw/ =~ RUBY_PLATFORM and defined?(TestReadline) and kind_of?(TestReadline) omit "Won't pass on mingw readline.so using 8.0.001" if /mingw/ =~ RUBY_PLATFORM and defined?(TestReadline) and kind_of?(TestReadline)
skip 'Needs GNU Readline 6 or later' if /mswin|mingw/ =~ RUBY_PLATFORM and defined?(TestReadline) and kind_of?(TestReadline) and Readline::VERSION < '6.0' omit 'Needs GNU Readline 6 or later' if /mswin|mingw/ =~ RUBY_PLATFORM and defined?(TestReadline) and kind_of?(TestReadline) and Readline::VERSION < '6.0'
bug6601 = '[ruby-core:45682]' bug6601 = '[ruby-core:45682]'
Readline::HISTORY << "hello" Readline::HISTORY << "hello"
wo = nil wo = nil
@ -452,10 +452,10 @@ module BasetestReadline
end end
def test_input_metachar_multibyte def test_input_metachar_multibyte
skip "Skip Editline" if /EditLine/n.match(Readline::VERSION) omit "Skip Editline" if /EditLine/n.match(Readline::VERSION)
unless Encoding.find("locale") == Encoding::UTF_8 unless Encoding.find("locale") == Encoding::UTF_8
return if assert_under_utf8 return if assert_under_utf8
skip 'this test needs UTF-8 locale' omit 'this test needs UTF-8 locale'
end end
bug6602 = '[ruby-core:45683]' bug6602 = '[ruby-core:45683]'
Readline::HISTORY << "\u3042\u3093" Readline::HISTORY << "\u3042\u3093"
@ -482,8 +482,8 @@ module BasetestReadline
end end
def test_refresh_line def test_refresh_line
skip "Only when refresh_line exists" unless Readline.respond_to?(:refresh_line) omit "Only when refresh_line exists" unless Readline.respond_to?(:refresh_line)
skip unless respond_to?(:assert_ruby_status) omit unless respond_to?(:assert_ruby_status)
bug6232 = '[ruby-core:43957] [Bug #6232] refresh_line after set_screen_size' bug6232 = '[ruby-core:43957] [Bug #6232] refresh_line after set_screen_size'
with_temp_stdio do |stdin, stdout| with_temp_stdio do |stdin, stdout|
replace_stdio(stdin.path, stdout.path) do replace_stdio(stdin.path, stdout.path) do
@ -548,7 +548,7 @@ module BasetestReadline
return unless Readline.respond_to?(:quoting_detection_proc=) return unless Readline.respond_to?(:quoting_detection_proc=)
unless Encoding.find("external") == Encoding::UTF_8 unless Encoding.find("external") == Encoding::UTF_8
return if assert_under_utf8 return if assert_under_utf8
skip 'this test needs UTF-8 locale' omit 'this test needs UTF-8 locale'
end end
passed_text = nil passed_text = nil
@ -586,7 +586,7 @@ module BasetestReadline
end end
def test_simple_completion def test_simple_completion
skip "Skip Editline" if /EditLine/n.match(Readline::VERSION) omit "Skip Editline" if /EditLine/n.match(Readline::VERSION)
line = nil line = nil
@ -609,8 +609,8 @@ module BasetestReadline
end end
def test_completion_with_completion_append_character def test_completion_with_completion_append_character
skip "Skip Editline" if /EditLine/n.match(Readline::VERSION) omit "Skip Editline" if /EditLine/n.match(Readline::VERSION)
skip "Readline.completion_append_character is not implemented" unless Readline.respond_to?(:completion_append_character=) omit "Readline.completion_append_character is not implemented" unless Readline.respond_to?(:completion_append_character=)
line = nil line = nil
append_character = Readline.completion_append_character append_character = Readline.completion_append_character
@ -683,9 +683,9 @@ module BasetestReadline
return unless Readline.respond_to?(:completion_quote_character) return unless Readline.respond_to?(:completion_quote_character)
if /solaris/i =~ RUBY_PLATFORM if /solaris/i =~ RUBY_PLATFORM
# http://rubyci.s3.amazonaws.com/solaris11s-sunc/ruby-trunk/log/20181228T102505Z.fail.html.gz # http://rubyci.s3.amazonaws.com/solaris11s-sunc/ruby-trunk/log/20181228T102505Z.fail.html.gz
skip 'This test does not succeed on Oracle Developer Studio for now' omit 'This test does not succeed on Oracle Developer Studio for now'
end end
skip 'Needs GNU Readline 6 or later' if /mswin|mingw/ =~ RUBY_PLATFORM and defined?(TestReadline) and kind_of?(TestReadline) and Readline::VERSION < '6.0' omit 'Needs GNU Readline 6 or later' if /mswin|mingw/ =~ RUBY_PLATFORM and defined?(TestReadline) and kind_of?(TestReadline) and Readline::VERSION < '6.0'
Readline.completion_proc = -> (_) { [] } Readline.completion_proc = -> (_) { [] }
Readline.completer_quote_characters = "'\"" Readline.completer_quote_characters = "'\""
@ -768,7 +768,7 @@ module BasetestReadline
return false if ENV['LC_ALL'] == 'UTF-8' return false if ENV['LC_ALL'] == 'UTF-8'
loc = caller_locations(1, 1)[0].base_label.to_s loc = caller_locations(1, 1)[0].base_label.to_s
assert_separately([{"LC_ALL"=>"UTF-8"}, "-r", __FILE__], <<SRC) assert_separately([{"LC_ALL"=>"UTF-8"}, "-r", __FILE__], <<SRC)
#skip "test \#{ENV['LC_ALL']}" #omit "test \#{ENV['LC_ALL']}"
#{self.class.name}.new(#{loc.dump}).run(Test::Unit::Runner.new) #{self.class.name}.new(#{loc.dump}).run(Test::Unit::Runner.new)
SRC SRC
return true return true