From 0d7e0eb2faa282e0c15faa60c62992ca5452e228 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Rodr=C3=ADguez?= Date: Sat, 2 May 2020 12:37:57 +0200 Subject: [PATCH] [rubygems/rubygems] Prefer `tr` to `gsub` when replacing path separators This is not detected by the `Performance/StringReplacement` cop, I guess because of using constants. But still seems like a good change. Co-authored-by: MSP-Greg https://github.com/rubygems/rubygems/commit/f862103133 --- lib/rubygems/installer.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rubygems/installer.rb b/lib/rubygems/installer.rb index 343037ebf5..cf676854dc 100644 --- a/lib/rubygems/installer.rb +++ b/lib/rubygems/installer.rb @@ -709,7 +709,7 @@ class Gem::Installer return if self.class.path_warning user_bin_dir = @bin_dir || Gem.bindir(gem_home) - user_bin_dir = user_bin_dir.gsub(File::SEPARATOR, File::ALT_SEPARATOR) if + user_bin_dir = user_bin_dir.tr(File::SEPARATOR, File::ALT_SEPARATOR) if File::ALT_SEPARATOR path = ENV['PATH']