From 0dc5e45028fdeeac5ae507d95f3616e9e74e7fa7 Mon Sep 17 00:00:00 2001 From: nagachika Date: Mon, 27 Mar 2017 16:57:39 +0000 Subject: [PATCH] merge revision(s) 57640: [Backport #13214] fileutils.rb: do not make root * lib/fileutils.rb (FileUtils#mkdir_p): no need to make root directory which should be exist and cannot be made with mkdir recent Cygwin can make a directory contains a colon. [Bug #13214] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@58180 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- lib/fileutils.rb | 1 + test/fileutils/test_fileutils.rb | 18 ++++++++++++++++++ version.h | 2 +- 3 files changed, 20 insertions(+), 1 deletion(-) diff --git a/lib/fileutils.rb b/lib/fileutils.rb index 748ebd7637..bc9e959fab 100644 --- a/lib/fileutils.rb +++ b/lib/fileutils.rb @@ -222,6 +222,7 @@ module FileUtils stack.push path path = File.dirname(path) end + stack.pop # root directory should exist stack.reverse_each do |dir| begin fu_mkdir dir, options[:mode] diff --git a/test/fileutils/test_fileutils.rb b/test/fileutils/test_fileutils.rb index 82380d434c..eecdd99242 100644 --- a/test/fileutils/test_fileutils.rb +++ b/test/fileutils/test_fileutils.rb @@ -903,6 +903,24 @@ class TestFileUtils < Test::Unit::TestCase mkdir_p '/' end + if /mswin|mingw|cygwin/ =~ RUBY_PLATFORM + def test_mkdir_p_root + if /cygwin/ =~ RUBY_PLATFORM + tmpdir = `cygpath -ma .`.chomp + else + tmpdir = Dir.pwd + end + skip "No drive letter" unless /\A[a-z]:/i =~ tmpdir + drive = "./#{$&}" + assert_file_not_exist drive + mkdir_p "#{tmpdir}/none/dir" + assert_directory "none/dir" + assert_file_not_exist drive + ensure + Dir.rmdir(drive) if drive and File.directory?(drive) + end + end + def test_mkdir_p_file_perm mkdir_p 'tmp/tmp/tmp', :mode => 07777 assert_directory 'tmp/tmp/tmp' diff --git a/version.h b/version.h index aa52c22aae..298b593aa3 100644 --- a/version.h +++ b/version.h @@ -1,6 +1,6 @@ #define RUBY_VERSION "2.3.3" #define RUBY_RELEASE_DATE "2017-03-28" -#define RUBY_PATCHLEVEL 289 +#define RUBY_PATCHLEVEL 290 #define RUBY_RELEASE_YEAR 2017 #define RUBY_RELEASE_MONTH 3