kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

Raise ArgumentError if host component is nil

Browse source 
From: oss92 <mohamed.o.alnagdy@gmail.com>
fix https://github.com/ruby/ruby/pull/1278

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62698 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
naruse 2018-03-08 16:07:54 +00:00
parent 897af5dfcd
commit 0f7b26ab4e
2 changed files with 14 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/net/http/generic_request.rb
View file

@ -14,6 +14,8 @@ class Net::HTTPGenericRequest
@response_has_body = resbody
if URI === uri_or_path then
raise ArgumentError, "not an HTTP URI" unless URI::HTTP === uri_or_path
raise ArgumentError, "no host component for URI" unless uri_or_path.hostname
@uri = uri_or_path.dup
host = @uri.hostname.dup
host << ":".freeze << @uri.port.to_s if @uri.port != @uri.default_port

12
test/net/http/test_http_request.rb
View file

@ -65,6 +65,18 @@ class HTTPRequestTest < Test::Unit::TestCase
'Bug #7381 - do not decode content if the user overrides'
end if Net::HTTP::HAVE_ZLIB
def test_initialize_GET_uri
req = Net::HTTP::Get.new(URI("http://example.com/foo"))
assert_equal "/foo", req.path
assert_equal "example.com", req['Host']
req = Net::HTTP::Get.new(URI("https://example.com/foo"))
assert_equal "/foo", req.path
assert_equal "example.com", req['Host']
assert_raise(ArgumentError){ Net::HTTP::Get.new(URI("urn:ietf:rfc:7231")) }
end
def test_header_set
req = Net::HTTP::Get.new '/'