kotovalexarian-likes-github
/
ruby--ruby
mirror of https://github.com/ruby/ruby.git
1
0
Fork 0
Code Releases Activity

Removed unnecessary `chomp` 

As `String#split` with the default argument drops trailing newline
as a separator, preceding `String#chomp` is futile.
This commit is contained in:
Nobuyoshi Nakada 2020-03-07 16:41:19 +09:00
parent 65aa68b009
commit 108f7536b3
No known key found for this signature in database
GPG Key ID: 4BC7D6DF58D8DF60
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/net/smtp.rb
View File

@ -1042,7 +1042,7 @@ module Net
return {} unless @string[3, 1] == '-' return {} unless @string[3, 1] == '-'
h = {} h = {}
@string.lines.drop(1).each do |line| @string.lines.drop(1).each do |line|
k, *v = line[4..-1].chomp.split k, *v = line[4..-1].split
h[k] = v h[k] = v
end end
h h

2
spec/mspec/tool/sync/sync-rubyspec.rb
View File

@ -135,7 +135,7 @@ def rebase_commits(impl)
else else
last_merge = `git log --grep='^#{impl.last_merge_message}' -n 1 --format='%H %ct'` last_merge = `git log --grep='^#{impl.last_merge_message}' -n 1 --format='%H %ct'`
end end
last_merge, commit_timestamp = last_merge.chomp.split(' ') last_merge, commit_timestamp = last_merge.split(' ')
raise "Could not find last merge" unless last_merge raise "Could not find last merge" unless last_merge
puts "Last merge is #{last_merge}" puts "Last merge is #{last_merge}"

2
test/ruby/test_process.rb
View File

@ -2381,7 +2381,7 @@ EOS
end end
w.close w.close
assert_equal "exec failed\n", r.gets assert_equal "exec failed\n", r.gets
vals = r.gets.chomp.split.map!(&:to_i) vals = r.gets.split.map!(&:to_i)
assert_operator vals[0], :>, vals[1], vals.inspect assert_operator vals[0], :>, vals[1], vals.inspect
_, status = Process.waitpid2(pid) _, status = Process.waitpid2(pid)
end end