kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

Clean up implementation of SOCKSSocket, its confusing and undocumented

Browse source
This commit is contained in:
Justin McNally 2019-10-07 22:12:17 -05:00 committed by Kazuhiro NISHIYAMA
parent 68e0bfcd4a
commit 10c2a08548
Notes: git 2019-11-01 18:40:45 +09:00 
Merged: https://github.com/ruby/ruby/pull/2539
1 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
ext/socket/sockssocket.c
View file

@ -13,13 +13,19 @@
#ifdef SOCKS
/*
* call-seq:
* SOCKSSocket.new(host, serv) => socket
* SOCKSSocket.new(host, port) => socket
*
* Opens a SOCKS connection to +host+ via the SOCKS server +serv+.
* Opens a SOCKS connection to +host+ via the SOCKS server.
*
* The SOCKS server configuration varies by implementation
*
* When using the Dante libsocks/libsocksd implementation it is configured as SOCKS_SERVER env var.
*
* See: https://manpages.debian.org/testing/dante-client/socksify.1.en.html for full env variable support.
*
*/
static VALUE
socks_init(VALUE sock, VALUE host, VALUE serv)
socks_init(VALUE sock, VALUE host, VALUE port)
{
static int init = 0;
@ -28,7 +34,7 @@ socks_init(VALUE sock, VALUE host, VALUE serv)
init = 1;
}
return rsock_init_inetsock(sock, host, serv, Qnil, Qnil, INET_SOCKS);
return rsock_init_inetsock(sock, host, port, Qnil, Qnil, INET_SOCKS);
}
#ifdef SOCKS5