kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

[ruby/rubygems] Don't make duplicated checks on directory safety

Browse source 
This seems to speed up `gem install` on Windows by more than 50%.

1970b1296d
This commit is contained in:
David Rodríguez 2021-09-30 15:52:05 +02:00 • committed by git
parent ef352c5865
commit 11720818f6
1 changed files with 6 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

11
lib/rubygems/package.rb
View file

@ -400,7 +400,7 @@ EOM
# extracted. # extracted.
def extract_tar_gz(io, destination_dir, pattern = "*") # :nodoc: def extract_tar_gz(io, destination_dir, pattern = "*") # :nodoc:
directories = [] if dir_mode directories = []
open_tar_gz io do |tar| open_tar_gz io do |tar|
tar.each do |entry| tar.each do |entry|
next unless File.fnmatch pattern, entry.full_name, File::FNM_DOTMATCH next unless File.fnmatch pattern, entry.full_name, File::FNM_DOTMATCH
@ -417,9 +417,11 @@ EOM
else else
File.dirname destination File.dirname destination
end end
directories << mkdir if directories
mkdir_p_safe mkdir, mkdir_options, destination_dir, entry.full_name unless directories.include?(mkdir)
mkdir_p_safe mkdir, mkdir_options, destination_dir, entry.full_name
directories << mkdir
end
File.open destination, 'wb' do |out| File.open destination, 'wb' do |out|
out.write entry.read out.write entry.read
@ -432,8 +434,7 @@ EOM
end end
end end
if directories if dir_mode
directories.uniq!
File.chmod(dir_mode, *directories) File.chmod(dir_mode, *directories)
end end
end end