1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00

[ruby/ostruct] method_missing is private

This commit is contained in:
Marc-Andre Lafortune 2020-09-14 14:06:49 -04:00 committed by Marc-André Lafortune
parent 606c009ce2
commit 125605abd9
Notes: git 2020-09-15 05:11:07 +09:00
2 changed files with 4 additions and 27 deletions

View file

@ -212,7 +212,7 @@ class OpenStruct
super
end
def method_missing(mid, *args) # :nodoc:
private def method_missing(mid, *args) # :nodoc:
len = args.length
if mname = mid[/.*(?==\z)/m]
if len != 1

View file

@ -7,43 +7,20 @@ describe "OpenStruct#method_missing when called with a method name ending in '='
end
it "raises an ArgumentError when not passed any additional arguments" do
-> { @os.method_missing(:test=) }.should raise_error(ArgumentError)
end
it "raises a TypeError when self is frozen" do
@os.freeze
-> { @os.method_missing(:test=, "test") }.should raise_error(RuntimeError)
end
it "creates accessor methods" do
@os.method_missing(:test=, "test")
@os.respond_to?(:test=).should be_true
@os.respond_to?(:test).should be_true
@os.test.should == "test"
@os.test = "changed"
@os.test.should == "changed"
-> { @os.send(:test=) }.should raise_error(ArgumentError)
end
end
describe "OpenStruct#method_missing when passed additional arguments" do
it "raises a NoMethodError when the key does not exist" do
os = OpenStruct.new
-> { os.method_missing(:test, 1, 2, 3) }.should raise_error(NoMethodError)
-> { os.test(1, 2, 3) }.should raise_error(NoMethodError)
end
ruby_version_is "2.7" do
it "raises an ArgumentError when the key exists" do
os = OpenStruct.new(test: 20)
-> { os.method_missing(:test, 1, 2, 3) }.should raise_error(ArgumentError)
-> { os.test(1, 2, 3) }.should raise_error(ArgumentError)
end
end
end
describe "OpenStruct#method_missing when not passed any additional arguments" do
it "returns the value for the passed method from the method/value table" do
os = OpenStruct.new(age: 20)
os.method_missing(:age).should eql(20)
os.method_missing(:name).should be_nil
end
end