kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

[rubygems/rubygems] Simplify host switching logic

Browse source 
This block was a branch and variable heavy way of saying use the
user-provided host if available, or fall-back to the default host if
none of the other options match. IMO the resultant single-if condition
is clearer in intentions

42dbb71cfa
This commit is contained in:
Thomas McDonald 2019-07-04 15:30:15 +01:00 • committed by Hiroshi SHIBATA
parent acb793b71c
commit 12ac0fa939
Notes: git 2020-05-08 14:14:25 +09:00
1 changed files with 3 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

15
lib/rubygems/commands/push_command.rb
View file

@ -52,23 +52,14 @@ The push command will use ~/.gem/credentials to authenticate to a server, but yo
gem_name = get_one_gem_name gem_name = get_one_gem_name
default_gem_server, push_host = get_hosts_for(gem_name) default_gem_server, push_host = get_hosts_for(gem_name)
default_host = nil @host = if @user_defined_host
user_defined_host = nil options[:host]
if @user_defined_host
user_defined_host = options[:host]
else
default_host = options[:host]
end
@host = if user_defined_host
user_defined_host
elsif default_gem_server elsif default_gem_server
default_gem_server default_gem_server
elsif push_host elsif push_host
push_host push_host
else else
default_host options[:host]
end end
sign_in @host sign_in @host