From 13c15beb68916b41f69e8d1e96f61478368ec9ac Mon Sep 17 00:00:00 2001 From: duerst Date: Wed, 19 Dec 2018 04:08:46 +0000 Subject: [PATCH] avoid passing unnecessary options to download method The option --unicode-beta for tool/downloader.rb introduced in r66448 must not be passed as an option to actual download machinery. Thanks to MSP-Greg (Greg L.) for bug report and patch. This closes issue #15434. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66449 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- tool/downloader.rb | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tool/downloader.rb b/tool/downloader.rb index 46f8bea96e..3cf98e9655 100644 --- a/tool/downloader.rb +++ b/tool/downloader.rb @@ -124,6 +124,11 @@ class Downloader options = options.dup url = URI(url) dryrun = options.delete(:dryrun) + + # remove from options (future use, see r66448), see L166 + unicode_beta = options.delete(:unicode_beta) + puts "never" if unicode_beta == 'assigned but unused variable...' + if name file = Pathname.new(under(dir, name)) else