kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

* ext/syck/rubyext.c (syck_genericresolver_node_import): should

Browse source 
not set instance variable "@kind" before initializing it.
  [ruby-dev:32677]

* ext/syck/rubyext.c (syck_resolver_initialize,
  syck_resolver_detect_implicit, syck_emitter_emit): remove unused
  variables.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_8@16075 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
knu 2008-04-18 10:00:18 +00:00
parent 892318561a
commit 158e1367e5
2 changed files with 12 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
ChangeLog
View file

@ -1,3 +1,13 @@
Fri Apr 18 18:56:57 2008 Akinori MUSHA <knu@iDaemons.org>
* ext/syck/rubyext.c (syck_genericresolver_node_import): should
not set instance variable "@kind" before initializing it.
[ruby-dev:32677]
* ext/syck/rubyext.c (syck_resolver_initialize,
syck_resolver_detect_implicit, syck_emitter_emit): remove unused
variables.
Fri Apr 18 18:54:57 2008 Akinori MUSHA <knu@iDaemons.org> Fri Apr 18 18:54:57 2008 Akinori MUSHA <knu@iDaemons.org>
* ext/syck/rubyext.c: Node#value defined twice. * ext/syck/rubyext.c: Node#value defined twice.

7
ext/syck/rubyext.c
View file

@ -917,7 +917,6 @@ static VALUE
syck_resolver_initialize( self ) syck_resolver_initialize( self )
VALUE self; VALUE self;
{ {
VALUE tags = rb_hash_new();
rb_ivar_set(self, s_tags, rb_hash_new()); rb_ivar_set(self, s_tags, rb_hash_new());
return self; return self;
} }
@ -952,7 +951,6 @@ VALUE
syck_resolver_detect_implicit( self, val ) syck_resolver_detect_implicit( self, val )
VALUE self, val; VALUE self, val;
{ {
char *type_id;
return rb_str_new2( "" ); return rb_str_new2( "" );
} }
@ -1308,7 +1306,6 @@ syck_genericresolver_node_import( self, node )
break; break;
case syck_seq_kind: case syck_seq_kind:
rb_iv_set(obj, "@kind", sym_seq);
v = rb_ary_new2( syck_seq_count( n ) ); v = rb_ary_new2( syck_seq_count( n ) );
for ( i = 0; i < syck_seq_count( n ); i++ ) for ( i = 0; i < syck_seq_count( n ); i++ )
{ {
@ -1319,10 +1316,10 @@ syck_genericresolver_node_import( self, node )
style = sym_inline; style = sym_inline;
} }
obj = rb_funcall( cSeq, s_new, 3, t, v, style ); obj = rb_funcall( cSeq, s_new, 3, t, v, style );
rb_iv_set(obj, "@kind", sym_seq);
break; break;
case syck_map_kind: case syck_map_kind:
rb_iv_set(obj, "@kind", sym_map);
v = rb_hash_new(); v = rb_hash_new();
for ( i = 0; i < syck_map_count( n ); i++ ) for ( i = 0; i < syck_map_count( n ); i++ )
{ {
@ -1333,6 +1330,7 @@ syck_genericresolver_node_import( self, node )
style = sym_inline; style = sym_inline;
} }
obj = rb_funcall( cMap, s_new, 3, t, v, style ); obj = rb_funcall( cMap, s_new, 3, t, v, style );
rb_iv_set(obj, "@kind", sym_map);
break; break;
} }
@ -2028,7 +2026,6 @@ syck_emitter_emit( argc, argv, self )
VALUE self; VALUE self;
{ {
VALUE oid, proc; VALUE oid, proc;
char *anchor_name;
SyckEmitter *emitter; SyckEmitter *emitter;
struct emitter_xtra *bonus; struct emitter_xtra *bonus;
SYMID symple; SYMID symple;