1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00

rexml: disable XPath 1.0 compatible "#{ELEMENT_NAME}" processing by default

It breaks backward compatibility than I thought. So it's disabled by
default. It means that REXML's XPath processor isn't compatible with
XPath 1.0. But it will be acceptable for users.

We can enable it by specifying "strict: true" to
REXML::XPathParser.new explicitly.

* lib/rexml/xpath.rb,
  lib/rexml/xpath_parser.rb: Accept "strict: true" option.

* test/rexml/test_contrib.rb,
  test/rexml/xpath/test_base.rb: Use not XPath 1.0 compatible behavior.

* test/rexml/test_jaxen.rb: Use XPath 1.0 compatible behavior.

* test/rss/test_1.0.rb,
  test/rss/test_dublincore.rb,
  spec/ruby/library/rexml/element/namespace_spec.rb,
  spec/ruby/library/rexml/element/namespaces_spec.rb,
  spec/ruby/library/rexml/element/prefixes_spec.rb: Enable again.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63278 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
kou 2018-04-28 01:36:18 +00:00
parent 75f4f699fd
commit 1d67b9de28
10 changed files with 28 additions and 34 deletions

View file

@ -1,8 +1,6 @@
require 'rexml/document'
require_relative '../../../spec_helper'
=begin
# FIXME
describe "REXML::Element#namespace" do
before :each do
@doc = REXML::Document.new("<a xmlns='1' xmlns:y='2'><b/><c xmlns:z='3'/></a>")
@ -27,4 +25,3 @@ describe "REXML::Element#namespace" do
@elem.namespace("z").should be_nil
end
end
=end

View file

@ -7,7 +7,6 @@ describe "REXML::Element#namespaces" do
@elem = doc.elements["//c"]
end
=begin
it "returns a hash of the namespaces" do
ns = {"y"=>"2", "z"=>"3", "xmlns"=>"1"}
@elem.namespaces.keys.sort.should == ns.keys.sort
@ -29,5 +28,4 @@ describe "REXML::Element#namespaces" do
values = ["2", "3", "1"]
@elem.namespaces.values.sort.should == values.sort
end
=end
end

View file

@ -7,7 +7,6 @@ describe "REXML::Element#prefixes" do
@elem = doc.elements["//c"]
end
=begin
it "returns an array of the prefixes of the namespaces" do
@elem.prefixes.should == ["y", "z"]
end
@ -15,7 +14,6 @@ describe "REXML::Element#prefixes" do
it "does not include the default namespace" do
@elem.prefixes.include?("xmlns").should == false
end
=end
it "returns an empty array if no namespace was defined" do
doc = REXML::Document.new "<root><something/></root>"