kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

* regcomp.c (noname_disable_map): don't optimize out group 0

Browse source 
Ruby's Regexp doesn't allow normal numbered groups if the regexp
  has named groups. On such case it optimizes out related NT_ENCLOSE.
  But even on the case it can use \g<0>.
  This fix not to remove NT_ENCLOSE whose regnum is 0.
  [ruby-core:75828] [Bug #12454]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55562 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
naruse 2016-07-01 19:37:43 +00:00
parent 3418a277d8
commit 1e3fc7dcfa
3 changed files with 13 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
ChangeLog
View file

@ -1,3 +1,12 @@
Sat Jul 2 04:26:14 2016 NARUSE, Yui <naruse@ruby-lang.org>
* regcomp.c (noname_disable_map): don't optimize out group 0
Ruby's Regexp doesn't allow normal numbered groups if the regexp
has named groups. On such case it optimizes out related NT_ENCLOSE.
But even on the case it can use \g<0>.
This fix not to remove NT_ENCLOSE whose regnum is 0.
[ruby-core:75828] [Bug #12454]
Sat Jul 2 03:09:27 2016 Naohisa Goto <ngotogenome@gmail.com> Sat Jul 2 03:09:27 2016 Naohisa Goto <ngotogenome@gmail.com>
* string.c: Partially reverts r55547 and r55555. * string.c: Partially reverts r55547 and r55555.

5
regcomp.c
View file

@ -1870,16 +1870,15 @@ noname_disable_map(Node** plink, GroupNumRemap* map, int* counter)
(*counter)++; (*counter)++;
map[en->regnum].new_val = *counter; map[en->regnum].new_val = *counter;
en->regnum = *counter; en->regnum = *counter;
r = noname_disable_map(&(en->target), map, counter);
} }
else { else if (en->regnum != 0) {
*plink = en->target; *plink = en->target;
en->target = NULL_NODE; en->target = NULL_NODE;
onig_node_free(node); onig_node_free(node);
r = noname_disable_map(plink, map, counter); r = noname_disable_map(plink, map, counter);
break;
} }
} }
else
r = noname_disable_map(&(en->target), map, counter); r = noname_disable_map(&(en->target), map, counter);
} }
break; break;

1
test/ruby/test_regexp.rb
View file

@ -441,6 +441,7 @@ class TestRegexp < Test::Unit::TestCase
assert_raise(RegexpError) { Regexp.new(")(") } assert_raise(RegexpError) { Regexp.new(")(") }
assert_raise(RegexpError) { Regexp.new('[\\40000000000') } assert_raise(RegexpError) { Regexp.new('[\\40000000000') }
assert_raise(RegexpError) { Regexp.new('[\\600000000000.') } assert_raise(RegexpError) { Regexp.new('[\\600000000000.') }
assert_raise(RegexpError) { Regexp.new("((?<v>))\\g<0>") }
end end
def test_unescape def test_unescape