kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

* insns.def (opt_plus): use - 1 instead of & (~1) to allow

Browse source 
compilers to use x86 LEA instruction (3 operand).
  Even if 3 operand LEA's latency is 3 cycle after SandyBridge,
  it reduces code size and can be faster because of super scalar.

* insns.def (opt_plus): calculate and use rb_int2big.
  On positive Fixnum overflow, `recv - 1 + obj` doesn't carry
  because recv's msb and obj's msb are 0, and resulted msb is 1.
  Therefore simply rshift and cast as signed long works fine.
  On negative Fixnum overflow, it will carry because both arguments'
  msb are 1, and resulted msb is also 1.
  In this case it needs to restore carried sign bit after rshift.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55515 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
naruse 2016-06-27 18:30:12 +00:00
parent 4b31485ad8
commit 1e791f438b
2 changed files with 21 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

15
ChangeLog
View file

@ -1,3 +1,18 @@
Tue Jun 28 02:41:32 2016 NARUSE, Yui <naruse@ruby-lang.org>
* insns.def (opt_plus): use `- 1` instead of `& (~1)` to allow
compilers to use x86 LEA instruction (3 operand).
Even if 3 operand LEA's latency is 3 cycle after SandyBridge,
it reduces code size and can be faster because of super scalar.
* insns.def (opt_plus): calculate and use rb_int2big.
On positive Fixnum overflow, `recv - 1 + obj` doesn't carry
because recv's msb and obj's msb are 0, and resulted msb is 1.
Therefore simply rshift and cast as signed long works fine.
On negative Fixnum overflow, it will carry because both arguments'
msb are 1, and resulted msb is also 1.
In this case it needs to restore carried sign bit after rshift.
Mon Jun 27 16:58:32 2016 Nobuyoshi Nakada <nobu@ruby-lang.org> Mon Jun 27 16:58:32 2016 Nobuyoshi Nakada <nobu@ruby-lang.org>
* lib/fileutils.rb (FileUtils#install): accecpt symbolic mode, as * lib/fileutils.rb (FileUtils#install): accecpt symbolic mode, as

17
insns.def
View file

@ -1381,18 +1381,13 @@ opt_plus
BASIC_OP_UNREDEFINED_P(BOP_PLUS,INTEGER_REDEFINED_OP_FLAG)) { BASIC_OP_UNREDEFINED_P(BOP_PLUS,INTEGER_REDEFINED_OP_FLAG)) {
/* fixnum + fixnum */ /* fixnum + fixnum */
#ifndef LONG_LONG_VALUE #ifndef LONG_LONG_VALUE
val = (recv + (obj & (~1))); VALUE msb = (VALUE)1 << ((sizeof(VALUE) * CHAR_BIT) - 1);
if ((~(recv ^ obj) & (recv ^ val)) & val = recv - 1 + obj;
((VALUE)0x01 << ((sizeof(VALUE) * CHAR_BIT) - 1))) { if ((~(recv ^ obj) & (recv ^ val)) & msb) {
val = rb_big_plus(rb_int2big(FIX2LONG(recv)), val = rb_int2big((SIGNED_VALUE)((val>>1) | (recv & msb)));
rb_int2big(FIX2LONG(obj))); }
}
#else #else
long a, b, c; val = LONG2NUM(FIX2LONG(recv) + FIX2LONG(obj));
a = FIX2LONG(recv);
b = FIX2LONG(obj);
c = a + b;
val = LONG2NUM(c);
#endif #endif
} }
else if (FLONUM_2_P(recv, obj) && else if (FLONUM_2_P(recv, obj) &&