From 20c5154f0b79faf83c9c889f12da7da1ba9d6eb1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Rodr=C3=ADguez?= Date: Thu, 15 Aug 2019 18:48:09 +0200 Subject: [PATCH] [bundler/bundler] Only chdir when necessary https://github.com/bundler/bundler/commit/07161ebc1a --- spec/bundler/quality_spec.rb | 30 ++++++++++++++---------------- 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/spec/bundler/quality_spec.rb b/spec/bundler/quality_spec.rb index bcb9412d4d..40e1a113f0 100644 --- a/spec/bundler/quality_spec.rb +++ b/spec/bundler/quality_spec.rb @@ -225,24 +225,22 @@ RSpec.describe "The library itself" do end it "can still be built" do - Dir.chdir(root) do - if ruby_core? - spec = Gem::Specification.load(gemspec.to_s) - spec.bindir = "libexec" - File.open(root.join("bundler.gemspec").to_s, "w") {|f| f.write spec.to_ruby } - gem_command! :build, root.join("bundler.gemspec") - FileUtils.rm(root.join("bundler.gemspec")) - else - gem_command! :build, gemspec - end + if ruby_core? + spec = Gem::Specification.load(gemspec.to_s) + spec.bindir = "libexec" + File.open(root.join("bundler.gemspec").to_s, "w") {|f| f.write spec.to_ruby } + Dir.chdir(root) { gem_command! :build, root.join("bundler.gemspec") } + FileUtils.rm(root.join("bundler.gemspec")) + else + Dir.chdir(root) { gem_command! :build, gemspec } + end - bundler_path = root.join("bundler-#{Bundler::VERSION}.gem") + bundler_path = root.join("bundler-#{Bundler::VERSION}.gem") - begin - expect(err).to be_empty, "bundler should build as a gem without warnings, but\n#{err}" - ensure - bundler_path.rmtree - end + begin + expect(err).to be_empty, "bundler should build as a gem without warnings, but\n#{err}" + ensure + bundler_path.rmtree end end