kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

io.c: chomp CR at the end of read buffer

Browse source 
* io.c (rb_io_getline_fast): chomp CR followed by LF but separated
  by the read buffer boundary.  [ruby-core:91707] [Bug #15642]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67188 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
nobu 2019-03-07 05:11:46 +00:00
parent 1598b5e7b3
commit 23488589b3
2 changed files with 19 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
io.c
View file

@ -3310,6 +3310,12 @@ rb_io_getline_fast(rb_io_t *fptr, rb_encoding *enc, int chomp)
read_buffered_data(RSTRING_PTR(str)+len, pending - chomplen, fptr);
fptr->rbuf.off += chomplen;
fptr->rbuf.len -= chomplen;
if (pending == 1 && chomplen == 1 && len > 0) {
if (RSTRING_PTR(str)[len-1] == '\r') {
rb_str_resize(str, --len);
break;
}
}
}
len += pending - chomplen;
if (cr != ENC_CODERANGE_BROKEN)

13
test/ruby/test_io.rb
View file

@ -233,6 +233,19 @@ class TestIO < Test::Unit::TestCase
assert_nil r.gets
r.close
end)
(0..3).each do |i|
pipe(proc do |w|
w.write("a" * ((4096 << i) - 4), "\r\n" "a\r\n")
w.close
end,
proc do |r|
r.gets
assert_equal "a", r.gets(chomp: true)
assert_nil r.gets
r.close
end)
end
end
def test_gets_chomp_rs_nil