kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

Return nil when argument to ObjectSpace.internal_class_of is T_IMEMO

Browse source 
The added test case crashes the interpreter because it makes
ObjectSpace.internal_class_of return the second VALUE slot of an AST
imemo object. The second VALUE slot of `struct rb_ast_struct` is
not a VALUE and not a pointer to a Ruby object.
This commit is contained in:
Alan Wu 2020-09-01 23:13:54 -04:00 committed by Aaron Patterson
parent 3a00f2a0f4
commit 24820d508b
Notes: git 2020-09-26 01:28:14 +09:00 
Merged: https://github.com/ruby/ruby/pull/3503
2 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
ext/objspace/objspace.c
View file

@ -895,9 +895,14 @@ objspace_internal_class_of(VALUE self, VALUE obj)
obj = (VALUE)DATA_PTR(obj); obj = (VALUE)DATA_PTR(obj);
} }
if (RB_TYPE_P(obj, T_IMEMO)) {
return Qnil;
}
else {
klass = CLASS_OF(obj); klass = CLASS_OF(obj);
return wrap_klass_iow(klass); return wrap_klass_iow(klass);
} }
}
/* /*
* call-seq: * call-seq:

5
test/objspace/test_objspace.rb
View file

@ -516,6 +516,11 @@ class TestObjSpace < Test::Unit::TestCase
assert_operator i, :>, 0 assert_operator i, :>, 0
end end
def test_internal_class_of_on_ast
children = ObjectSpace.reachable_objects_from(RubyVM::AbstractSyntaxTree.parse("kadomatsu"))
children.each {|child| ObjectSpace.internal_class_of(child).itself} # this used to crash
end
def traverse_super_classes klass def traverse_super_classes klass
while klass while klass
klass = ObjectSpace.internal_super_of(klass) klass = ObjectSpace.internal_super_of(klass)