From 27144de2bd95c5886c3d4400c3b8aea932b856f1 Mon Sep 17 00:00:00 2001 From: Jeremy Evans Date: Fri, 20 Sep 2019 12:18:07 -0700 Subject: [PATCH] Fix documentation for ENV.each to return ENV Also have spec check that it returns ENV. Mostly from burdettelamar@yahoo.com (Burdette Lamar). Fixes [Bug #16164] --- hash.c | 4 ++-- spec/ruby/core/env/shared/each.rb | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hash.c b/hash.c index e9d994bf70..8b84a14484 100644 --- a/hash.c +++ b/hash.c @@ -5276,9 +5276,9 @@ env_each_value(VALUE ehash) /* * call-seq: - * ENV.each { |name, value| block } -> Hash + * ENV.each { |name, value| block } -> ENV * ENV.each -> Enumerator - * ENV.each_pair { |name, value| block } -> Hash + * ENV.each_pair { |name, value| block } -> ENV * ENV.each_pair -> Enumerator * * Yields each environment variable +name+ and +value+. diff --git a/spec/ruby/core/env/shared/each.rb b/spec/ruby/core/env/shared/each.rb index 8a262e4862..261ad3a2a6 100644 --- a/spec/ruby/core/env/shared/each.rb +++ b/spec/ruby/core/env/shared/each.rb @@ -8,7 +8,7 @@ describe :env_each, shared: true do ENV.clear ENV["foo"] = "bar" ENV["baz"] = "boo" - ENV.send(@method) { |k, v| e << [k, v] } + ENV.send(@method) { |k, v| e << [k, v] }.should equal(ENV) e.should include(["foo", "bar"]) e.should include(["baz", "boo"]) ensure