1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00

merge revision(s) 579645d9f8: [Backport #17033]

Fixed infinite loop at error in printing cause [Bug #17033]
This commit is contained in:
nagachika 2020-07-23 12:13:30 +09:00
parent 4be9bf1f67
commit 27fa1c61b7
3 changed files with 26 additions and 2 deletions

View file

@ -348,6 +348,7 @@ rb_ec_error_print(rb_execution_context_t * volatile ec, volatile VALUE errinfo)
volatile uint8_t raised_flag = ec->raised_flag;
volatile VALUE errat = Qundef;
volatile VALUE emesg = Qundef;
volatile bool written = false;
if (NIL_P(errinfo))
return;
@ -362,7 +363,10 @@ rb_ec_error_print(rb_execution_context_t * volatile ec, volatile VALUE errinfo)
emesg = rb_get_message(errinfo);
}
rb_error_write(errinfo, emesg, errat, Qnil, Qnil, Qnil);
if (!written) {
written = true;
rb_error_write(errinfo, emesg, errat, Qnil, Qnil, Qnil);
}
EC_POP_TAG();
ec->errinfo = errinfo;

View file

@ -824,6 +824,26 @@ end.join
}
end
def test_cause_exception_in_cause_message
assert_in_out_err([], "#{<<~"begin;"}\n#{<<~'end;'}") do |outs, errs, status|
begin;
exc = Class.new(StandardError) do
def initialize(obj, cnt)
super(obj)
@errcnt = cnt
end
def to_s
return super if @errcnt <= 0
@errcnt -= 1
raise "xxx"
end
end.new("ok", 10)
raise "[Bug #17033]", cause: exc
end;
assert_equal(1, errs.count {|m| m.include?("[Bug #17033]")}, proc {errs.pretty_inspect})
end
end
def test_anonymous_message
assert_in_out_err([], "raise Class.new(RuntimeError), 'foo'", [], /foo\n/)
end

View file

@ -2,7 +2,7 @@
# define RUBY_VERSION_MINOR RUBY_API_VERSION_MINOR
#define RUBY_VERSION_TEENY 1
#define RUBY_RELEASE_DATE RUBY_RELEASE_YEAR_STR"-"RUBY_RELEASE_MONTH_STR"-"RUBY_RELEASE_DAY_STR
#define RUBY_PATCHLEVEL 100
#define RUBY_PATCHLEVEL 101
#define RUBY_RELEASE_YEAR 2020
#define RUBY_RELEASE_MONTH 7