diff --git a/ChangeLog b/ChangeLog index 5414571a45..f6597f0f32 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +Sun Feb 13 22:43:03 2005 Masatoshi SEKI + + * lib/drb/drb.rb (DRbServer): add default_safe_level, safe_level, + config[:safe_level] ([druby-ja:120]) + + * test/drb/test_drb.rb, ut_eval.rb, ut_safe1.rb: ditto. + Sun Feb 13 16:56:52 2005 GOTOU Yuuzou * lib/webrick/cgi.rb (WEBrick::CGI.start): should set reason-phrase diff --git a/lib/drb/drb.rb b/lib/drb/drb.rb index eb68f909da..ab2cba894f 100644 --- a/lib/drb/drb.rb +++ b/lib/drb/drb.rb @@ -1186,6 +1186,7 @@ module DRb @@argc_limit = 256 @@load_limit = 256 * 102400 @@verbose = false + @@safe_level = 0 # Set the default value for the :argc_limit option. # @@ -1215,6 +1216,10 @@ module DRb @@idconv = idconv end + def self.default_sefe_level(level) + @@level = level + end + # Set the default value of the :verbose option. # # See #new(). The initial default value is false. @@ -1233,7 +1238,8 @@ module DRb :verbose => @@verbose, :tcp_acl => @@acl, :load_limit => @@load_limit, - :argc_limit => @@argc_limit + :argc_limit => @@argc_limit, + :safe_level => @@safe_level } default_config.update(hash) end @@ -1298,6 +1304,7 @@ module DRb @front = front @idconv = @config[:idconv] + @safe_level = @config[:safe_level] @grp = ThreadGroup.new @thread = run @@ -1326,6 +1333,8 @@ module DRb # The configuration of this DRbServer attr_reader :config + attr_reader :safe_level + # Set whether to operate in verbose mode. # # In verbose mode, failed calls are logged to stdout. @@ -1391,7 +1400,7 @@ module DRb # # These methods are not callable via dRuby. INSECURE_METHOD = [ - :__send__, :instance_eval, :module_eval, :class_eval + :__send__ ] # Has a method been included in the list of insecure methods? @@ -1436,6 +1445,7 @@ module DRb class InvokeMethod # :nodoc: def initialize(drb_server, client) @drb_server = drb_server + @safe_level = drb_server.safe_level @client = client end @@ -1443,10 +1453,25 @@ module DRb @result = nil @succ = false setup_message - if @block - @result = perform_with_block + + if $SAFE < @safe_level + if @block + @result = Thread.new { + $SAFE = @safe_level + perform_with_block + }.value + else + @result = Thread.new { + $SAFE = @safe_level + perform_without_block + }.value + end else - @result = perform_without_block + if @block + @result = perform_with_block + else + @result = perform_without_block + end end @succ = true if @msg_id == :to_ary && @result.class == Array diff --git a/test/drb/test_drb.rb b/test/drb/test_drb.rb index 6764e913ca..ae8ba4252a 100644 --- a/test/drb/test_drb.rb +++ b/test/drb/test_drb.rb @@ -217,7 +217,7 @@ class TestDRbEval < Test::Unit::TestCase @ext.stop_service end - def test_01_safe1_eval + def test_01_safe1_safe4_eval assert_raises(SecurityError) do @there.method_missing(:instance_eval, 'ENV.inspect') end @@ -235,6 +235,19 @@ class TestDRbEval < Test::Unit::TestCase assert_raises(SecurityError) do remote_class.module_eval('ENV.inspect') end + + four = @there.four + assert_equal(1, four.method_missing(:send, :eval, '1')) + + remote_class = four.remote_class + + assert_raises(SecurityError) do + remote_class.class_eval('ENV.inspect') + end + + assert_raises(SecurityError) do + remote_class.module_eval('ENV.inspect') + end end end diff --git a/test/drb/ut_eval.rb b/test/drb/ut_eval.rb index 6a81e17d05..4df963e7cd 100644 --- a/test/drb/ut_eval.rb +++ b/test/drb/ut_eval.rb @@ -2,6 +2,14 @@ require 'drb/drb' require 'drb/extserv' class EvalAttack + def initialize + @four = DRb::DRbServer.new('druby://localhost:0', self, {:safe_level => 4}) + end + + def four + DRbObject.new_with_uri(@four.uri) + end + def remote_class DRbObject.new(self.class) end @@ -17,7 +25,7 @@ if __FILE__ == $0 $SAFE = 1 - DRb.start_service('druby://localhost:0', EvalAttack.new) + DRb.start_service('druby://localhost:0', EvalAttack.new, {:safe_level => 2}) es = DRb::ExtServ.new(ARGV.shift, ARGV.shift) DRb.thread.join end diff --git a/test/drb/ut_safe1.rb b/test/drb/ut_safe1.rb index 761bdff4b1..4df8e1e5a1 100644 --- a/test/drb/ut_safe1.rb +++ b/test/drb/ut_safe1.rb @@ -8,9 +8,8 @@ if __FILE__ == $0 it end - $SAFE = 1 - - DRb.start_service('druby://localhost:0', [1, 2, 'III', 4, "five", 6]) + DRb.start_service('druby://localhost:0', [1, 2, 'III', 4, "five", 6], + {:safe_level => 1}) es = DRb::ExtServ.new(ARGV.shift, ARGV.shift) DRb.thread.join end