From 2bfa1025a91679a5e1d513255d298126af32099d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=8D=9C=E9=83=A8=E6=98=8C=E5=B9=B3?= Date: Wed, 26 Feb 2020 13:17:08 +0900 Subject: [PATCH] .github: let "make leaked-globals" run in parallel This target can be a build matrix. Also it does not make sense to test it on mjit. --- .github/workflows/macos.yml | 4 +--- .github/workflows/mjit.yml | 2 -- .github/workflows/ubuntu.yml | 6 +++--- 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml index 9c3662232d..86d1280da3 100644 --- a/.github/workflows/macos.yml +++ b/.github/workflows/macos.yml @@ -5,7 +5,7 @@ jobs: runs-on: macos-latest strategy: matrix: - test_task: [ "check", "test-bundler", "test-bundled-gems" ] + test_task: [ "check", "test-bundler", "test-bundled-gems", "leaked-globals" ] fail-fast: false if: "!contains(github.event.head_commit.message, '[ci skip]')" steps: @@ -52,8 +52,6 @@ jobs: # Remove minitest from TEST_BUNDLED_GEMS_ALLOW_FAILURES if https://github.com/seattlerb/minitest/pull/798 is resolved # rss needs to add workaround for the non rexml environment TEST_BUNDLED_GEMS_ALLOW_FAILURES: "minitest,xmlrpc,rss,rexml" - - run: make -s leaked-globals - working-directory: build - uses: k0kubun/action-slack@v2.0.0 with: payload: | diff --git a/.github/workflows/mjit.yml b/.github/workflows/mjit.yml index a71518d228..eaadeca4ce 100644 --- a/.github/workflows/mjit.yml +++ b/.github/workflows/mjit.yml @@ -54,8 +54,6 @@ jobs: working-directory: build - run: make $JOBS -s test-spec working-directory: build - - run: make -s leaked-globals - working-directory: build - uses: k0kubun/action-slack@v2.0.0 with: payload: | diff --git a/.github/workflows/ubuntu.yml b/.github/workflows/ubuntu.yml index f448f20633..2b48ea9648 100644 --- a/.github/workflows/ubuntu.yml +++ b/.github/workflows/ubuntu.yml @@ -4,7 +4,7 @@ jobs: make: strategy: matrix: - test_task: [ "check", "test-bundler", "test-bundled-gems", "test-all TESTS=--repeat-count=2" ] + test_task: [ "check", "test-bundler", "test-bundled-gems", "test-all TESTS=--repeat-count=2", "leaked-globals" ] os: [ubuntu-latest, ubuntu-16.04] exclude: - test_task: test-bundler @@ -13,6 +13,8 @@ jobs: os: ubuntu-16.04 - test_task: "test-all TESTS=--repeat-count=2" os: ubuntu-16.04 + - test_task: leaked-globals + os: ubuntu-16.04 fail-fast: false runs-on: ${{ matrix.os }} if: "!contains(github.event.head_commit.message, '[ci skip]')" @@ -64,8 +66,6 @@ jobs: # Remove minitest from TEST_BUNDLED_GEMS_ALLOW_FAILURES if https://github.com/seattlerb/minitest/pull/798 is resolved # rss needs to add workaround for the non rexml environment TEST_BUNDLED_GEMS_ALLOW_FAILURES: "minitest,xmlrpc,rss" - - run: make -s leaked-globals - working-directory: build - uses: k0kubun/action-slack@v2.0.0 with: payload: |