From 2e2ef819345d7268085cd5f066471f06c70496d3 Mon Sep 17 00:00:00 2001 From: nahi Date: Sat, 6 Dec 2003 08:26:15 +0000 Subject: [PATCH] * lib/soap/soap.rb(SOAP::Env.getenv): allow upcase environment variable as well as downcase one. * lib/soap/netHttpClient.rb(SOAP::NetHttpClient#proxy=): check URI. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@5124 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- ChangeLog | 7 +++++++ lib/soap/netHttpClient.rb | 5 +++++ lib/soap/soap.rb | 2 +- 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index aa008502ea..d6d1946d57 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +Sat Dec 6 17:23:00 2003 NAKAMURA, Hiroshi + + * lib/soap/soap.rb(SOAP::Env.getenv): allow upcase environment variable + as well as downcase one. + + * lib/soap/netHttpClient.rb(SOAP::NetHttpClient#proxy=): check URI. + Fri Dec 5 23:22:30 2003 Nobuyoshi Nakada * lib/test/unit/assertions.rb (Test::Unit::Assertions::assert_raises, diff --git a/lib/soap/netHttpClient.rb b/lib/soap/netHttpClient.rb index a0b3b7ca26..4505de815e 100644 --- a/lib/soap/netHttpClient.rb +++ b/lib/soap/netHttpClient.rb @@ -40,6 +40,11 @@ class NetHttpClient @proxy = nil else @proxy = URI.parse(proxy_str) + if @proxy.scheme == nil or @proxy.scheme.downcase != 'http' or + @proxy.host == nil or @proxy.port == nil + raise ArgumentError.new("unsupported proxy `#{proxy_str}'") + end + @proxy end end diff --git a/lib/soap/soap.rb b/lib/soap/soap.rb index ea2b4db2e1..d00d89b05b 100644 --- a/lib/soap/soap.rb +++ b/lib/soap/soap.rb @@ -100,7 +100,7 @@ end module Env def self.getenv(name) - ENV[name.downcase] || ENV[name] + ENV[name.downcase] || ENV[name.upcase] end use_proxy = getenv('soap_use_proxy') == 'on'