From 31663e9e64b538087e90466d98e61f1fba6ca8a0 Mon Sep 17 00:00:00 2001 From: Benoit Daloze Date: Fri, 13 Mar 2020 13:52:40 +0100 Subject: [PATCH] [rubygems/rubygems] These specs seem to work just fine on jruby https://github.com/rubygems/rubygems/commit/a0219b9f27 --- test/rubygems/test_gem_ext_cmake_builder.rb | 2 -- test/rubygems/test_gem_ext_configure_builder.rb | 8 -------- 2 files changed, 10 deletions(-) diff --git a/test/rubygems/test_gem_ext_cmake_builder.rb b/test/rubygems/test_gem_ext_cmake_builder.rb index 0eb1a4c0f5..05673e1b6d 100644 --- a/test/rubygems/test_gem_ext_cmake_builder.rb +++ b/test/rubygems/test_gem_ext_cmake_builder.rb @@ -10,8 +10,6 @@ class TestGemExtCmakeBuilder < Gem::TestCase # Details: https://github.com/rubygems/rubygems/issues/1270#issuecomment-177368340 skip "CmakeBuilder doesn't work on Windows." if Gem.win_platform? - skip "CmakeBuilder doesn't work on JRuby." if Gem.java_platform? && ENV["CI"] - system('cmake', out: IO::NULL, err: [:child, :out]) skip 'cmake not present' unless $?.success? diff --git a/test/rubygems/test_gem_ext_configure_builder.rb b/test/rubygems/test_gem_ext_configure_builder.rb index 6e51f1880d..ac8a861e17 100644 --- a/test/rubygems/test_gem_ext_configure_builder.rb +++ b/test/rubygems/test_gem_ext_configure_builder.rb @@ -18,10 +18,6 @@ class TestGemExtConfigureBuilder < Gem::TestCase end def test_self_build - if java_platform? && ENV["CI"] - skip("failing on jruby") - end - skip("test_self_build skipped on MS Windows (VC++)") if vc_windows? File.open File.join(@ext, './configure'), 'w' do |configure| @@ -49,10 +45,6 @@ class TestGemExtConfigureBuilder < Gem::TestCase end def test_self_build_fail - if java_platform? && ENV["CI"] - skip("failing on jruby") - end - skip("test_self_build_fail skipped on MS Windows (VC++)") if vc_windows? output = []