kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

rb_strftime_with_timespec: do not goto into a branch

Browse source 
I'm not necessarily against every goto in general, but jumping into a
branch is definitely a bad idea.  Better refactor.
This commit is contained in:
卜部昌平 2020-06-17 14:49:16 +09:00
parent b5eeb3453e
commit 31a770ac48
Notes: git 2020-06-29 11:06:50 +09:00 
Merged: https://github.com/ruby/ruby/pull/3247
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
strftime.c
View file

@ -266,8 +266,7 @@ rb_strftime_with_timespec(VALUE ftime, const char *format, size_t format_len,
static const char ampm[][3] = { "AM", "PM", }; static const char ampm[][3] = { "AM", "PM", };
if (format == NULL || format_len == 0 || vtm == NULL) { if (format == NULL || format_len == 0 || vtm == NULL) {
err: goto err;
return 0;
} }
if (enc && if (enc &&
@ -911,6 +910,9 @@ rb_strftime_with_timespec(VALUE ftime, const char *format, size_t format_len,
rb_str_set_len(ftime, len); rb_str_set_len(ftime, len);
rb_str_resize(ftime, len); rb_str_resize(ftime, len);
return ftime; return ftime;
err:
return 0;
} }
static size_t static size_t