From 33025d976865859744535edb63063a102bec73f5 Mon Sep 17 00:00:00 2001 From: bronzdoc Date: Thu, 25 Jul 2019 22:11:37 -0600 Subject: [PATCH] [rubygems/rubygems] Make error code a constant and remove TODO comment https://github.com/rubygems/rubygems/commit/3d6c7c92e4 --- lib/rubygems/gemcutter_utilities.rb | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/lib/rubygems/gemcutter_utilities.rb b/lib/rubygems/gemcutter_utilities.rb index 21f83e72d1..1b89946cb7 100644 --- a/lib/rubygems/gemcutter_utilities.rb +++ b/lib/rubygems/gemcutter_utilities.rb @@ -7,6 +7,8 @@ require 'rubygems/text' module Gem::GemcutterUtilities + ERROR_CODE = 1 + include Gem::Text attr_writer :host @@ -76,7 +78,7 @@ module Gem::GemcutterUtilities self.host = host if host unless self.host alert_error "You must specify a gem server" - terminate_interaction 1 # TODO: question this + terminate_interaction(ERROR_CODE) end if allowed_push_host @@ -153,7 +155,7 @@ module Gem::GemcutterUtilities Gem.configuration.api_keys[key] else alert_error "No such API key. Please add it to your configuration (done automatically on initial `gem push`)." - terminate_interaction 1 # TODO: question this + terminate_interaction(ERROR_CODE) end end @@ -177,7 +179,7 @@ module Gem::GemcutterUtilities message = "#{error_prefix}: #{message}" if error_prefix say clean_text(message) - terminate_interaction 1 # TODO: question this + terminate_interaction(ERROR_CODE) end end