kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

* lib/net/smtp.rb (Net::SMTP#critical): Always return a

Browse source 
Net::SMTP::Response.  Patch by Pawel Veselov.
  [ruby-trunk - Bug #9125]
* test/net/smtp/test_smtp.rb:  Test for the above.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43954 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
drbrain 2013-12-02 05:18:04 +00:00
parent 673efdceef
commit 34e57abf23
3 changed files with 21 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
ChangeLog
View file

@ -1,3 +1,10 @@
Mon Dec 2 14:16:52 2013 Eric Hodel <drbrain@segment7.net>
* lib/net/smtp.rb (Net::SMTP#critical): Always return a
Net::SMTP::Response. Patch by Pawel Veselov.
[ruby-trunk - Bug #9125]
* test/net/smtp/test_smtp.rb: Test for the above.
Mon Dec 2 05:52:33 2013 Eric Hodel <drbrain@segment7.net>
* lib/rubygems: Update to RubyGems master baa965b. Notable changes:

2
lib/net/smtp.rb
View file

@ -942,7 +942,7 @@ module Net
end
def critical
return '200 dummy reply code' if @error_occurred
return Response.parse('200 dummy reply code') if @error_occurred
begin
return yield()
rescue Exception

13
test/net/smtp/test_smtp.rb
View file

@ -21,6 +21,19 @@ module Net
end
end
def test_critical
smtp = Net::SMTP.new 'localhost', 25
assert_raises RuntimeError do
smtp.send :critical do
raise 'fail on purpose'
end
end
assert_kind_of Net::SMTP::Response, smtp.send(:critical),
'[Bug #9125]'
end
def test_esmtp
smtp = Net::SMTP.new 'localhost', 25
assert smtp.esmtp