1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00

spec: skip Process wait specs on MJIT

until [Bug #14867] is fixed. I want to start running CI with MJIT
enabled before fixing the problem.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63731 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
k0kubun 2018-06-23 08:29:20 +00:00
parent ea0cede5aa
commit 359dd59db2
5 changed files with 125 additions and 112 deletions

View file

@ -39,3 +39,9 @@ end
def with_feature(*features, &block) def with_feature(*features, &block)
FeatureGuard.new(*features).run_if(:with_feature, &block) FeatureGuard.new(*features).run_if(:with_feature, &block)
end end
MSpecEnv.class_eval do
def without_feature(*features, &block)
FeatureGuard.new(*features).run_unless(:without_feature, &block)
end
end

View file

@ -14,19 +14,21 @@ describe "Process.wait2" do
end end
end end
platform_is_not :windows do without_feature :mjit do # [Bug #14867]
it "returns the pid and status of child process" do platform_is_not :windows do
pidf = Process.fork { Process.exit! 99 } it "returns the pid and status of child process" do
results = Process.wait2 pidf = Process.fork { Process.exit! 99 }
results.size.should == 2 results = Process.wait2
pidw, status = results results.size.should == 2
pidf.should == pidw pidw, status = results
status.exitstatus.should == 99 pidf.should == pidw
status.exitstatus.should == 99
end
end
it "raises a StandardError if no child processes exist" do
lambda { Process.wait2 }.should raise_error(Errno::ECHILD)
lambda { Process.wait2 }.should raise_error(StandardError)
end end
end end
it "raises a StandardError if no child processes exist" do
lambda { Process.wait2 }.should raise_error(Errno::ECHILD)
lambda { Process.wait2 }.should raise_error(StandardError)
end
end end

View file

@ -12,79 +12,81 @@ describe "Process.wait" do
end end
end end
it "raises an Errno::ECHILD if there are no child processes" do without_feature :mjit do # [Bug #14867]
lambda { Process.wait }.should raise_error(Errno::ECHILD) it "raises an Errno::ECHILD if there are no child processes" do
end lambda { Process.wait }.should raise_error(Errno::ECHILD)
platform_is_not :windows do
it "returns its childs pid" do
pid = Process.spawn(ruby_cmd('exit'))
Process.wait.should == pid
end end
it "sets $? to a Process::Status" do platform_is_not :windows do
pid = Process.spawn(ruby_cmd('exit')) it "returns its childs pid" do
Process.wait pid = Process.spawn(ruby_cmd('exit'))
$?.should be_kind_of(Process::Status) Process.wait.should == pid
$?.pid.should == pid
end
it "waits for any child process if no pid is given" do
pid = Process.spawn(ruby_cmd('exit'))
Process.wait.should == pid
lambda { Process.kill(0, pid) }.should raise_error(Errno::ESRCH)
end
it "waits for a specific child if a pid is given" do
pid1 = Process.spawn(ruby_cmd('exit'))
pid2 = Process.spawn(ruby_cmd('exit'))
Process.wait(pid2).should == pid2
Process.wait(pid1).should == pid1
lambda { Process.kill(0, pid1) }.should raise_error(Errno::ESRCH)
lambda { Process.kill(0, pid2) }.should raise_error(Errno::ESRCH)
end
it "coerces the pid to an Integer" do
pid1 = Process.spawn(ruby_cmd('exit'))
Process.wait(mock_int(pid1)).should == pid1
lambda { Process.kill(0, pid1) }.should raise_error(Errno::ESRCH)
end
# This spec is probably system-dependent.
it "waits for a child whose process group ID is that of the calling process" do
pid1 = Process.spawn(ruby_cmd('exit'), pgroup: true)
pid2 = Process.spawn(ruby_cmd('exit'))
Process.wait(0).should == pid2
Process.wait.should == pid1
end
# This spec is probably system-dependent.
it "doesn't block if no child is available when WNOHANG is used" do
read, write = IO.pipe
pid = Process.fork do
read.close
Signal.trap("TERM") { Process.exit! }
write << 1
write.close
sleep
end end
Process.wait(pid, Process::WNOHANG).should be_nil it "sets $? to a Process::Status" do
pid = Process.spawn(ruby_cmd('exit'))
Process.wait
$?.should be_kind_of(Process::Status)
$?.pid.should == pid
end
# wait for the child to setup its TERM handler it "waits for any child process if no pid is given" do
write.close pid = Process.spawn(ruby_cmd('exit'))
read.read(1) Process.wait.should == pid
read.close lambda { Process.kill(0, pid) }.should raise_error(Errno::ESRCH)
end
Process.kill("TERM", pid) it "waits for a specific child if a pid is given" do
Process.wait.should == pid pid1 = Process.spawn(ruby_cmd('exit'))
end pid2 = Process.spawn(ruby_cmd('exit'))
Process.wait(pid2).should == pid2
Process.wait(pid1).should == pid1
lambda { Process.kill(0, pid1) }.should raise_error(Errno::ESRCH)
lambda { Process.kill(0, pid2) }.should raise_error(Errno::ESRCH)
end
it "always accepts flags=0" do it "coerces the pid to an Integer" do
pid = Process.spawn(ruby_cmd('exit')) pid1 = Process.spawn(ruby_cmd('exit'))
Process.wait(-1, 0).should == pid Process.wait(mock_int(pid1)).should == pid1
lambda { Process.kill(0, pid) }.should raise_error(Errno::ESRCH) lambda { Process.kill(0, pid1) }.should raise_error(Errno::ESRCH)
end
# This spec is probably system-dependent.
it "waits for a child whose process group ID is that of the calling process" do
pid1 = Process.spawn(ruby_cmd('exit'), pgroup: true)
pid2 = Process.spawn(ruby_cmd('exit'))
Process.wait(0).should == pid2
Process.wait.should == pid1
end
# This spec is probably system-dependent.
it "doesn't block if no child is available when WNOHANG is used" do
read, write = IO.pipe
pid = Process.fork do
read.close
Signal.trap("TERM") { Process.exit! }
write << 1
write.close
sleep
end
Process.wait(pid, Process::WNOHANG).should be_nil
# wait for the child to setup its TERM handler
write.close
read.read(1)
read.close
Process.kill("TERM", pid)
Process.wait.should == pid
end
it "always accepts flags=0" do
pid = Process.spawn(ruby_cmd('exit'))
Process.wait(-1, 0).should == pid
lambda { Process.kill(0, pid) }.should raise_error(Errno::ESRCH)
end
end end
end end
end end

View file

@ -8,41 +8,43 @@ describe "Process.waitall" do
end end
end end
it "returns an empty array when there are no children" do without_feature :mjit do # [Bug #14867]
Process.waitall.should == [] it "returns an empty array when there are no children" do
end Process.waitall.should == []
it "takes no arguments" do
lambda { Process.waitall(0) }.should raise_error(ArgumentError)
end
platform_is_not :windows do
it "waits for all children" do
pids = []
pids << Process.fork { Process.exit! 2 }
pids << Process.fork { Process.exit! 1 }
pids << Process.fork { Process.exit! 0 }
Process.waitall
pids.each { |pid|
lambda { Process.kill(0, pid) }.should raise_error(Errno::ESRCH)
}
end end
it "returns an array of pid/status pairs" do it "takes no arguments" do
pids = [] lambda { Process.waitall(0) }.should raise_error(ArgumentError)
pids << Process.fork { Process.exit! 2 } end
pids << Process.fork { Process.exit! 1 }
pids << Process.fork { Process.exit! 0 } platform_is_not :windows do
a = Process.waitall it "waits for all children" do
a.should be_kind_of(Array) pids = []
a.size.should == 3 pids << Process.fork { Process.exit! 2 }
pids.each { |pid| pids << Process.fork { Process.exit! 1 }
pid_status = a.assoc(pid) pids << Process.fork { Process.exit! 0 }
pid_status.should be_kind_of(Array) Process.waitall
pid_status.size.should == 2 pids.each { |pid|
pid_status.first.should == pid lambda { Process.kill(0, pid) }.should raise_error(Errno::ESRCH)
pid_status.last.should be_kind_of(Process::Status) }
} end
it "returns an array of pid/status pairs" do
pids = []
pids << Process.fork { Process.exit! 2 }
pids << Process.fork { Process.exit! 1 }
pids << Process.fork { Process.exit! 0 }
a = Process.waitall
a.should be_kind_of(Array)
a.size.should == 3
pids.each { |pid|
pid_status = a.assoc(pid)
pid_status.should be_kind_of(Array)
pid_status.size.should == 2
pid_status.first.should == pid
pid_status.last.should be_kind_of(Process::Status)
}
end
end end
end end
end end

View file

@ -49,4 +49,5 @@ class MSpecScript
MSpec.enable_feature :fiber_library MSpec.enable_feature :fiber_library
MSpec.enable_feature :fork if respond_to?(:fork, true) MSpec.enable_feature :fork if respond_to?(:fork, true)
MSpec.enable_feature :encoding MSpec.enable_feature :encoding
MSpec.enable_feature :mjit if defined?(RubyVM::MJIT) && RubyVM::MJIT.enabled?
end end