kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

Warn local variables which conflict with new numbered parameters

Browse source
This commit is contained in:
Nobuyoshi Nakada 2019-08-29 22:07:45 +09:00
parent 092f31e7e2
commit 3754e15530
No known key found for this signature in database
GPG key ID: 4BC7D6DF58D8DF60
2 changed files with 17 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

13
defs/id.def
View file

@ -57,6 +57,19 @@ firstline, predefined = __LINE__+1, %[\
nil nil
_ UScore _ UScore
# MUST be successive
_0 NUMPARAM_0
_1 NUMPARAM_1
_2 NUMPARAM_2
_3 NUMPARAM_3
_4 NUMPARAM_4
_5 NUMPARAM_5
_6 NUMPARAM_6
_7 NUMPARAM_7
_8 NUMPARAM_8
_9 NUMPARAM_9
"/*NULL*/" NULL "/*NULL*/" NULL
empty? empty?
eql? eql?

4
parse.y
View file

@ -11652,6 +11652,10 @@ arg_var(struct parser_params *p, ID id)
static void static void
local_var(struct parser_params *p, ID id) local_var(struct parser_params *p, ID id)
{ {
if (id >= idNUMPARAM_0 && id <= idNUMPARAM_9) {
rb_warn1("`_%d' is used as numbered parameter",
WARN_I((int)(id - idNUMPARAM_0)));
}
vtable_add(p->lvtbl->vars, id); vtable_add(p->lvtbl->vars, id);
if (p->lvtbl->used) { if (p->lvtbl->used) {
vtable_add(p->lvtbl->used, (ID)p->ruby_sourceline); vtable_add(p->lvtbl->used, (ID)p->ruby_sourceline);