diff --git a/bignum.c b/bignum.c index 239f799a95..766677a7ab 100644 --- a/bignum.c +++ b/bignum.c @@ -6041,12 +6041,15 @@ rb_big_divide(VALUE x, VALUE y, ID op) } else if (RB_FLOAT_TYPE_P(y)) { if (op == '/') { - return DBL2NUM(rb_big2dbl(x) / RFLOAT_VALUE(y)); + double dx = rb_big2dbl(x); + return rb_flo_div_flo(DBL2NUM(dx), y); } else { + VALUE v; double dy = RFLOAT_VALUE(y); if (dy == 0.0) rb_num_zerodiv(); - return rb_dbl2big(rb_big2dbl(x) / dy); + v = rb_big_divide(x, y, '/'); + return rb_dbl2big(RFLOAT_VALUE(v)); } } else { @@ -6179,6 +6182,7 @@ double rb_big_fdiv_double(VALUE x, VALUE y) { double dx, dy; + VALUE v; dx = big2dbl(x); if (FIXNUM_P(y)) { @@ -6199,7 +6203,8 @@ rb_big_fdiv_double(VALUE x, VALUE y) else { return NUM2DBL(rb_num_coerce_bin(x, y, rb_intern("fdiv"))); } - return dx / dy; + v = rb_flo_div_flo(DBL2NUM(dx), DBL2NUM(dy)); + return NUM2DBL(v); } VALUE diff --git a/enumerator.c b/enumerator.c index 466e064560..274583a3de 100644 --- a/enumerator.c +++ b/enumerator.c @@ -2790,15 +2790,16 @@ static double arith_seq_float_step_size(double beg, double end, double step, int excl) { double const epsilon = DBL_EPSILON; - double n = (end - beg) / step; - double err = (fabs(beg) + fabs(end) + fabs(end - beg)) / fabs(step) * epsilon; + double n, err; - if (isinf(step)) { - return step > 0 ? beg <= end : beg >= end; - } if (step == 0) { return HUGE_VAL; } + n = (end - beg) / step; + err = (fabs(beg) + fabs(end) + fabs(end - beg)) / fabs(step) * epsilon; + if (isinf(step)) { + return step > 0 ? beg <= end : beg >= end; + } if (err > 0.5) err = 0.5; if (excl) { if (n <= 0) return 0; diff --git a/marshal.c b/marshal.c index 15ed3ae705..73d36e2a32 100644 --- a/marshal.c +++ b/marshal.c @@ -401,8 +401,8 @@ w_float(double d, struct dump_arg *arg) w_cstr("nan", arg); } else if (d == 0.0) { - if (1.0/d < 0) w_cstr("-0", arg); - else w_cstr("0", arg); + if (signbit(d)) w_cstr("-0", arg); + else w_cstr("0", arg); } else { int decpt, sign, digs, len = 0; diff --git a/numeric.c b/numeric.c index 6ec7caf921..f80a40a728 100644 --- a/numeric.c +++ b/numeric.c @@ -2485,15 +2485,16 @@ static double ruby_float_step_size(double beg, double end, double unit, int excl) { const double epsilon = DBL_EPSILON; - double n = (end - beg)/unit; - double err = (fabs(beg) + fabs(end) + fabs(end-beg)) / fabs(unit) * epsilon; + double n, err; + if (unit == 0) { + return HUGE_VAL; + } + n= (end - beg)/unit; + err = (fabs(beg) + fabs(end) + fabs(end-beg)) / fabs(unit) * epsilon; if (isinf(unit)) { return unit > 0 ? beg <= end : beg >= end; } - if (unit == 0) { - return HUGE_VAL; - } if (err>0.5) err=0.5; if (excl) { if (n<=0) return 0; @@ -3707,7 +3708,7 @@ fix_fdiv_double(VALUE x, VALUE y) return rb_big_fdiv_double(rb_int2big(FIX2LONG(x)), y); } else if (RB_TYPE_P(y, T_FLOAT)) { - return (double)FIX2LONG(x) / RFLOAT_VALUE(y); + return double_div_double(FIX2LONG(x), RFLOAT_VALUE(y)); } else { return NUM2DBL(rb_num_coerce_bin(x, y, rb_intern("fdiv"))); @@ -3777,19 +3778,16 @@ fix_divide(VALUE x, VALUE y, ID op) return rb_big_div(x, y); } else if (RB_TYPE_P(y, T_FLOAT)) { - { - double div; - if (op == '/') { - div = (double)FIX2LONG(x) / RFLOAT_VALUE(y); - return DBL2NUM(div); + double d = FIX2LONG(x); + return rb_flo_div_flo(DBL2NUM(d), y); } else { + VALUE v; if (RFLOAT_VALUE(y) == 0) rb_num_zerodiv(); - div = (double)FIX2LONG(x) / RFLOAT_VALUE(y); - return rb_dbl2big(floor(div)); + v = fix_divide(x, y, '/'); + return flo_floor(0, 0, v); } - } } else { if (RB_TYPE_P(y, T_RATIONAL) && diff --git a/vsnprintf.c b/vsnprintf.c index d221e757bf..04184d7a6a 100644 --- a/vsnprintf.c +++ b/vsnprintf.c @@ -1250,7 +1250,7 @@ cvt(double value, int ndigits, int flags, char *sign, int *decpt, int ch, int *l if (value < 0) { value = -value; *sign = '-'; - } else if (value == 0.0 && 1.0/value < 0) { + } else if (value == 0.0 && signbit(value)) { *sign = '-'; } else { *sign = '\000';