1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00

[rubygems/rubygems] Fix RuboCop offenses

These offenses appear when you create a gem with
`bundle gem foo` and run `rubocop` over it.

Initially, there were around 45 offenses detected,
but with #3731 and this, the number of offenses
have been reduced to 2.

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>

fe9dcaa1b4
This commit is contained in:
Utkarsh Gupta 2020-06-19 16:14:18 +05:30 committed by Hiroshi SHIBATA
parent 2b73f26fde
commit 3b0d2a3d6d
Notes: git 2020-07-15 16:05:56 +09:00
8 changed files with 20 additions and 6 deletions

View file

@ -1,3 +1,5 @@
# frozen_string_literal: true
source "https://rubygems.org" source "https://rubygems.org"
# Specify your gem's dependencies in <%= config[:name] %>.gemspec # Specify your gem's dependencies in <%= config[:name] %>.gemspec

View file

@ -1,3 +1,5 @@
# frozen_string_literal: true
require "bundler/gem_tasks" require "bundler/gem_tasks"
<% default_task_names = [config[:test_task]].compact -%> <% default_task_names = [config[:test_task]].compact -%>
<% case config[:test] -%> <% case config[:test] -%>
@ -27,7 +29,7 @@ RuboCop::RakeTask.new
<% default_task_names.unshift(:clobber, :compile) -%> <% default_task_names.unshift(:clobber, :compile) -%>
require "rake/extensiontask" require "rake/extensiontask"
task :build => :compile task build: :compile
Rake::ExtensionTask.new("<%= config[:underscored_name] %>") do |ext| Rake::ExtensionTask.new("<%= config[:underscored_name] %>") do |ext|
ext.lib_dir = "lib/<%= config[:namespaced_path] %>" ext.lib_dir = "lib/<%= config[:namespaced_path] %>"

View file

@ -1,3 +1,5 @@
# frozen_string_literal: true
#!/usr/bin/env ruby #!/usr/bin/env ruby
require "bundler/setup" require "bundler/setup"

View file

@ -1,3 +1,5 @@
# frozen_string_literal: true
require "<%= config[:namespaced_path] %>/version" require "<%= config[:namespaced_path] %>/version"
<%- if config[:ext] -%> <%- if config[:ext] -%>
require "<%= config[:namespaced_path] %>/<%= config[:underscored_name] %>" require "<%= config[:namespaced_path] %>/<%= config[:underscored_name] %>"

View file

@ -1,3 +1,5 @@
# frozen_string_literal: true
<%- config[:constant_array].each_with_index do |c, i| -%> <%- config[:constant_array].each_with_index do |c, i| -%>
<%= " " * i %>module <%= c %> <%= " " * i %>module <%= c %>
<%- end -%> <%- end -%>

View file

@ -1,3 +1,5 @@
# frozen_string_literal: true
require_relative "lib/<%=config[:namespaced_path]%>/version" require_relative "lib/<%=config[:namespaced_path]%>/version"
Gem::Specification.new do |spec| Gem::Specification.new do |spec|
@ -6,8 +8,8 @@ Gem::Specification.new do |spec|
spec.authors = [<%= config[:author].inspect %>] spec.authors = [<%= config[:author].inspect %>]
spec.email = [<%= config[:email].inspect %>] spec.email = [<%= config[:email].inspect %>]
spec.summary = %q{TODO: Write a short summary, because RubyGems requires one.} spec.summary = "TODO: Write a short summary, because RubyGems requires one."
spec.description = %q{TODO: Write a longer description or delete this line.} spec.description = "TODO: Write a longer description or delete this line."
spec.homepage = "TODO: Put your gem's website or public repo URL here." spec.homepage = "TODO: Put your gem's website or public repo URL here."
<%- if config[:mit] -%> <%- if config[:mit] -%>
spec.license = "MIT" spec.license = "MIT"
@ -22,9 +24,7 @@ Gem::Specification.new do |spec|
# Specify which files should be added to the gem when it is released. # Specify which files should be added to the gem when it is released.
# The `git ls-files -z` loads the files in the RubyGem that have been added into git. # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
spec.files = Dir.chdir(File.expand_path("..", __FILE__)) do spec.files = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
`git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
end
spec.bindir = "exe" spec.bindir = "exe"
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
spec.require_paths = ["lib"] spec.require_paths = ["lib"]

View file

@ -1,3 +1,5 @@
# frozen_string_literal: true
RSpec.describe <%= config[:constant_name] %> do RSpec.describe <%= config[:constant_name] %> do
it "has a version number" do it "has a version number" do
expect(<%= config[:constant_name] %>::VERSION).not_to be nil expect(<%= config[:constant_name] %>::VERSION).not_to be nil

View file

@ -1,3 +1,5 @@
# frozen_string_literal: true
require "bundler/setup" require "bundler/setup"
require "<%= config[:namespaced_path] %>" require "<%= config[:namespaced_path] %>"