kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

* lib/soap/generator.rb (SOAP::SOAPGenerator#encode_tag): do not dump

Browse source 
XML attribute which value is nil.  value "" and nil both were dumped
          as 'attr="value"'.  [ruby-dev:29395]


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@10830 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
nahi 2006-09-02 03:11:02 +00:00
parent 97c6bc5ffd
commit 40cefc9844
2 changed files with 19 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
ChangeLog
View file

@ -1,3 +1,9 @@
Sat Sep 2 12:06:35 2006 NAKAMURA, Hiroshi <nahi@ruby-lang.org>
* lib/soap/generator.rb (SOAP::SOAPGenerator#encode_tag): do not dump
XML attribute which value is nil. value "" and nil both were dumped
as 'attr="value"'. [ruby-dev:29395]
Sat Sep 2 12:00:32 2006 NAKAMURA, Hiroshi <nahi@ruby-lang.org>
* lib/csv.rb (CSV::IOReader#initialize): use String#[](pos, len)

20
lib/soap/generator.rb
View file

@ -156,16 +156,22 @@ public
end
def encode_tag(elename, attrs = nil)
if !attrs or attrs.empty?
if attrs.nil? or attrs.empty?
@buf << "\n#{ @indent }<#{ elename }>"
elsif attrs.size == 1
key, value = attrs.shift
@buf << %Q[\n#{ @indent }<#{ elename } #{ key }="#{ value }">]
return
end
ary = []
attrs.each do |key, value|
ary << %Q[#{ key }="#{ value }"] unless value.nil?
end
case ary.size
when 0
@buf << "\n#{ @indent }<#{ elename }>"
when 1
@buf << %Q[\n#{ @indent }<#{ elename } #{ ary[0] }>]
else
@buf << "\n#{ @indent }<#{ elename } " <<
attrs.collect { |key, value|
%Q[#{ key }="#{ value }"]
}.join("\n#{ @indent }#{ @indentstr * 2 }") <<
ary.join("\n#{ @indent }#{ @indentstr * 2 }") <<
'>'
end
end