From 437800d3b0bdacf30b82fff15dd5532fbf65c3ab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=8D=9C=E9=83=A8=E6=98=8C=E5=B9=B3?= Date: Wed, 21 Sep 2022 10:03:30 +0900 Subject: [PATCH] getenv: is in stdlib.h getenv is a very basic function that has been in stdlib.h since ISO/IEC 9899:1990. There is absolutely zero need for us to redeclare. pty.c already includes stdlib.h out of the box so we need nothing. --- ext/etc/etc.c | 8 ++++++-- ext/pty/pty.c | 2 +- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/ext/etc/etc.c b/ext/etc/etc.c index 4cd941f586..c355fe117a 100644 --- a/ext/etc/etc.c +++ b/ext/etc/etc.c @@ -47,8 +47,12 @@ static VALUE sGroup; #define HAVE_UNAME 1 #endif -#ifndef _WIN32 -char *getenv(); +#ifdef STDC_HEADERS +# include +#else +# ifdef HAVE_STDLIB_H +# include +# endif #endif char *getlogin(); diff --git a/ext/pty/pty.c b/ext/pty/pty.c index 155d215942..acec33f9bf 100644 --- a/ext/pty/pty.c +++ b/ext/pty/pty.c @@ -170,7 +170,7 @@ establishShell(int argc, VALUE *argv, struct pty_info *info, { int master, slave, status = 0; rb_pid_t pid; - char *p, *getenv(); + char *p; VALUE v; struct child_info carg; char errbuf[32];