kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

[rubygems/rubygems] Require ext only in validate_extension, mention gemspec in warning.

Browse source 
https://github.com/rubygems/rubygems/commit/5e31e1a421
This commit is contained in:
Josef Šimánek 2020-05-09 00:23:19 +02:00 • committed by Hiroshi SHIBATA
parent b7adb10e39
commit 464e094fce
Notes: git 2020-06-05 07:33:43 +09:00
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/rubygems/specification_policy.rb
View file

@ -1,4 +1,3 @@
require 'rubygems/ext'
require 'rubygems/user_interaction'
class Gem::SpecificationPolicy
@ -421,13 +420,14 @@ http://spdx.org/licenses or '#{Gem::Licenses::NONSTANDARD}' for a nonstandard li
end
def validate_extensions # :nodoc:
require 'rubygems/ext'
builder = Gem::Ext::Builder.new(@specification)
rake_extension = @specification.extensions.any? {|s| builder.builder_for(s) == Gem::Ext::RakeBuilder }
rake_dependency = @specification.dependencies.any? {|d| d.name == 'rake'}
warning <<-WARNING if rake_extension && !rake_dependency
You have specified rake based extension, but rake is not added as dependency. It is recommended to add rake as a dependency since there's no guarantee rake will be already installed.
You have specified rake based extension, but rake is not added as dependency. It is recommended to add rake as a dependency in gemspec since there's no guarantee rake will be already installed.
WARNING
end