kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

rb_rational_raw: make a denominator always positive

Browse source
This commit is contained in:
Kenta Murata 2020-01-17 10:41:03 +09:00
parent 73618d84e8
commit 47465ab1cc
No known key found for this signature in database
GPG key ID: CEFE8AFB6081B062
3 changed files with 26 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
ext/-test-/rational/rat.c
View file

@ -29,9 +29,17 @@ gcd_gmp(VALUE x, VALUE y)
#define gcd_gmp rb_f_notimplement #define gcd_gmp rb_f_notimplement
#endif #endif
static VALUE
s_rational_raw(VALUE klass, VALUE x, VALUE y)
{
return rb_rational_raw(x, y);
}
void void
Init_rational(VALUE klass) Init_rational(VALUE klass)
{ {
rb_define_method(rb_cInteger, "gcd_normal", gcd_normal, 1); rb_define_method(rb_cInteger, "gcd_normal", gcd_normal, 1);
rb_define_method(rb_cInteger, "gcd_gmp", gcd_gmp, 1); rb_define_method(rb_cInteger, "gcd_gmp", gcd_gmp, 1);
rb_define_singleton_method(rb_cRational, "raw", s_rational_raw, 2);
} }

4
rational.c
View file

@ -1927,6 +1927,10 @@ rb_gcdlcm(VALUE self, VALUE other)
VALUE VALUE
rb_rational_raw(VALUE x, VALUE y) rb_rational_raw(VALUE x, VALUE y)
{ {
if (INT_NEGATIVE_P(y)) {
x = rb_int_uminus(x);
y = rb_int_uminus(y);
}
return nurat_s_new_internal(rb_cRational, x, y); return nurat_s_new_internal(rb_cRational, x, y);
} }

14
test/-ext-/rational/test_rat.rb
View file

@ -29,4 +29,18 @@ class TestRational < Test::Unit::TestCase
rescue NotImplementedError rescue NotImplementedError
end end
end end
def test_rb_rational_raw
rat = Rational.raw(1, 2)
assert_equal(1, rat.numerator)
assert_equal(2, rat.denominator)
rat = Rational.raw(-1, 2)
assert_equal(-1, rat.numerator)
assert_equal(2, rat.denominator)
rat = Rational.raw(1, -2)
assert_equal(-1, rat.numerator)
assert_equal(2, rat.denominator)
end
end end